refactor(wallet): Rename Wallet.classic_address to Wallet.address
#601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckniffen
reviewed
Jun 17, 2023
justinr1234
reviewed
Jun 17, 2023
JST5000
changed the title
Wallet.classic_address to Wallet.addressWallet.classic_address to Wallet.address
pdp2121
approved these changes
Jun 21, 2023
jonathanlei
approved these changes
Jun 23, 2023
ckniffen
approved these changes
Jun 25, 2023
JST5000
added a commit
that referenced
this pull request
Jun 28, 2023
…#601) * Remove classic_address from Wallet * Re-add the `classic_address` alias
JST5000
added a commit
that referenced
this pull request
Jun 28, 2023
…#601) * Remove classic_address from Wallet * Re-add the `classic_address` alias
JST5000
added a commit
that referenced
this pull request
Jul 5, 2023
…#601) * Remove classic_address from Wallet * Re-add the `classic_address` alias
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
classic_addressis jargon for most people - we should instead name itaddressContext of Change
We already were planning on adding a new alias, but in the spirit of having a clear API, this PR is instead planning to just set
addressto the new name.classic_addressis only named that to differentiate itself fromx-addresswhich is a newer standard which is not supported at the ledger level. (You have to decodex-addressesback toclassic_addressesbefore submitting a transaction to the ledger) - For a concept as basic as what an account on the XRPL is, we don't want to require understanding that nuance.Type of Change
Test Plan
CI Passes
Note: Originally this was a breaking change, but after discussion we've changed it to just affect the defaults we use - while keeping
classic_addressas an alias.