Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #710] Use network_id to identify faucet_url #715

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

[Fix #710] Use network_id to identify faucet_url #715

wants to merge 14 commits into from

Commits on Jun 12, 2024

  1. [Fix XRPLF#710] Use network_id to identify faucet_url 

    - move the utility function _get_network_id_and_build_version into client.py file for convinience
    @ckeshava
    ckeshava committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    ea6365a View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. additional check to prevent wasteful ServerInfo() requests

    @ckeshava
    ckeshava committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    23d3eb3 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Update xrpl/asyncio/wallet/wallet_generation.py 

    Co-authored-by: Mayukha Vadari <mvadari@gmail.com>
    @ckeshava @mvadari
    ckeshava and mvadari authored Jul 1, 2024
    Configuration menu
    Copy the full SHA
    56430f3 View commit details
    Browse the repository at this point in the history

  2. address PR comments

    @ckeshava
    ckeshava committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    ab918dc View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. refactor the generate faucet wallet logic

    @ckeshava
    ckeshava committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    afcb4d3 View commit details
    Browse the repository at this point in the history

  2. remove extra checks on the existence of client.network_id

    @ckeshava
    ckeshava committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    7f93914 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into faucet_url_logic

    @ckeshava
    ckeshava authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    cf3d8e5 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. address PR comments

    @ckeshava
    ckeshava committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    f06e5c1 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md 

    Co-authored-by: Mayukha Vadari <mvadari@gmail.com>
    @ckeshava @mvadari
    ckeshava and mvadari authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    bb62029 View commit details
    Browse the repository at this point in the history

  3. Update xrpl/asyncio/wallet/wallet_generation.py 

    Co-authored-by: Mayukha Vadari <mvadari@gmail.com>
    @ckeshava @mvadari
    ckeshava and mvadari authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    3881c7b View commit details
    Browse the repository at this point in the history

  4. Use a global dict map between network_id and URL

    @ckeshava
    ckeshava committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    0839082 View commit details
    Browse the repository at this point in the history

  5. address PR comments

    @ckeshava
    ckeshava committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    fe616ec View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Merge branch 'main' into faucet_url_logic

    @ckeshava
    ckeshava authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e346219 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Merge branch 'main' into faucet_url_logic

    @ckeshava
    ckeshava authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c30f772 View commit details
    Browse the repository at this point in the history