Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add feature RPC #719

Merged
merged 7 commits into from
Jul 8, 2024
Merged

feat: add feature RPC #719

merged 7 commits into from
Jul 8, 2024

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Jul 1, 2024

High Level Overview of Change

This PR adds the feature RPC to the models.

Context of Change

There is now a non-admin user version of this RPC: XRPLF/rippled#4781

Type of Change

  • New feature (non-breaking change which adds functionality)

Did you update CHANGELOG.md?

  • Yes
  • No, this change does not impact library users

Test Plan

Added integration tests.

@mvadari mvadari changed the title feaet: add feature RPC feat: add feature RPC Jul 1, 2024
@mvadari mvadari requested review from khancode and ckeshava July 1, 2024 13:22
CHANGELOG.md Show resolved Hide resolved
xrpl/models/requests/request.py Outdated Show resolved Hide resolved
xrpl/models/requests/request.py Show resolved Hide resolved
tests/integration/reqs/test_feature.py Outdated Show resolved Hide resolved
tests/integration/reqs/test_feature.py Outdated Show resolved Hide resolved
tests/integration/reqs/test_feature.py Show resolved Hide resolved
@mvadari mvadari requested a review from ckeshava July 2, 2024 19:15
Copy link
Collaborator

@ckeshava ckeshava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, tq

@justinr1234 justinr1234 merged commit 70ed9c0 into main Jul 8, 2024
21 checks passed
@justinr1234 justinr1234 deleted the feature branch July 8, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants