comment

XRPLF · Nov 13, 2024 · 1eceaf2 · 1eceaf2
1 parent c619289
commit 1eceaf2
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/packages/ripple-binary-codec/test/signing-data-encoding.test.ts b/packages/ripple-binary-codec/test/signing-data-encoding.test.ts
@@ -73,6 +73,8 @@ describe('Signing data', function () {
     const customPaymentDefinitions = JSON.parse(
       JSON.stringify(normalDefinitions),
     )
+
+    // custom number would need to updated in case it has been used by an existing transaction type
     customPaymentDefinitions.TRANSACTION_TYPES.Payment = 200
 
     const newDefs = new XrplDefinitions(customPaymentDefinitions)
@@ -176,6 +178,8 @@ describe('Signing data', function () {
     const customPaymentDefinitions = JSON.parse(
       JSON.stringify(normalDefinitions),
     )
+
+    // custom number would need to updated in case it has been used by an existing transaction type
     customPaymentDefinitions.TRANSACTION_TYPES.Payment = 200
 
     const newDefs = new XrplDefinitions(customPaymentDefinitions)