Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace elliptic/hash.js/bn.js with noble-curves/noble-hashes #2272

Open
sublimator opened this issue Apr 13, 2023 · 0 comments · Fixed by #2273
Open

Replace elliptic/hash.js/bn.js with noble-curves/noble-hashes #2272

sublimator opened this issue Apr 13, 2023 · 0 comments · Fixed by #2273
Assignees
@ckniffen
Labels
3.0

Comments

@sublimator
Copy link
Contributor

sublimator commented Apr 13, 2023 •
edited
Loading

See: https://github.com/paulmillr/noble-curves
Exploration @ #2273
@mvadari mvadari linked a pull request Apr 13, 2023 that will close this issue
feat: use noble libs for cryptography #2273
Merged
32 tasks
@sublimator sublimator changed the title Replace elliptic/hash.js with noble-curves/noble-hashes Replace elliptic/hash.js/bn.js with noble-curves/noble-hashes May 2, 2023
@sublimator sublimator mentioned this issue May 5, 2023
Open
@ckniffen ckniffen added the 3.0 label Jul 28, 2023
@ckniffen ckniffen self-assigned this Sep 1, 2023
ckniffen pushed a commit that referenced this issue Oct 9, 2023
@sublimator
feat: use @noble and @Scure libraries for cryptography (#2273)
f05e314 
Switch to using `@noble/hashes`, `@noble/curves`, `@scure/base`,
`@scure/bip32`, and `@scure/bip39`. This replaces `crypto` polyfills
(such as `crypto-browserify`), `create-hash`, `elliptic`, `hash.js`,
`bn.js` (both versions), and their many dependencies.  This also means 
there are 33 less dependencies downloaded when running a fresh 
`npm install` and will make the project much easier to maintain.

This reduces the bundle size by 44% (82kb minified and gzipped) over
the current 3.0 branch as well as reducing the amount of configuration
required to bundle.

Closes #1814, #1817, #2272, and #2306
ckniffen added a commit that referenced this issue Oct 9, 2023
@sublimator @ckniffen
feat: use @noble and @Scure libraries for cryptography (#2273)
4480185 
Switch to using `@noble/hashes`, `@noble/curves`, `@scure/base`,
`@scure/bip32`, and `@scure/bip39`. This replaces `crypto` polyfills
(such as `crypto-browserify`), `create-hash`, `elliptic`, `hash.js`,
`bn.js` (both versions), and their many dependencies.  This also means
there are 33 less dependencies downloaded when running a fresh
`npm install` and will make the project much easier to maintain.

This reduces the bundle size by 44% (82kb minified and gzipped) over
the current 3.0 branch as well as reducing the amount of configuration
required to bundle.

Closes #1814, #1817, #2272, and #2306

Co-authored-by: Caleb Kniffen <ckniffen@ripple.com>
ckniffen added a commit that referenced this issue Oct 18, 2023
@sublimator @ckniffen
feat: use @noble and @Scure libraries for cryptography (#2273)
2e7f85a 
Switch to using `@noble/hashes`, `@noble/curves`, `@scure/base`,
`@scure/bip32`, and `@scure/bip39`. This replaces `crypto` polyfills
(such as `crypto-browserify`), `create-hash`, `elliptic`, `hash.js`,
`bn.js` (both versions), and their many dependencies.  This also means
there are 33 less dependencies downloaded when running a fresh
`npm install` and will make the project much easier to maintain.

This reduces the bundle size by 44% (82kb minified and gzipped) over
the current 3.0 branch as well as reducing the amount of configuration
required to bundle.

Closes #1814, #1817, #2272, and #2306

Co-authored-by: Caleb Kniffen <ckniffen@ripple.com>
ckniffen added a commit that referenced this issue Oct 25, 2023
@sublimator @ckniffen
feat: use @noble and @Scure libraries for cryptography (#2273)
ebd0d2d 
Switch to using `@noble/hashes`, `@noble/curves`, `@scure/base`,
`@scure/bip32`, and `@scure/bip39`. This replaces `crypto` polyfills
(such as `crypto-browserify`), `create-hash`, `elliptic`, `hash.js`,
`bn.js` (both versions), and their many dependencies.  This also means
there are 33 less dependencies downloaded when running a fresh
`npm install` and will make the project much easier to maintain.

This reduces the bundle size by 44% (82kb minified and gzipped) over
the current 3.0 branch as well as reducing the amount of configuration
required to bundle.

Closes #1814, #1817, #2272, and #2306

Co-authored-by: Caleb Kniffen <ckniffen@ripple.com>
ckniffen added a commit that referenced this issue Nov 1, 2023
@sublimator @ckniffen
feat: use @noble and @Scure libraries for cryptography (#2273)
36325c5 
Switch to using `@noble/hashes`, `@noble/curves`, `@scure/base`,
`@scure/bip32`, and `@scure/bip39`. This replaces `crypto` polyfills
(such as `crypto-browserify`), `create-hash`, `elliptic`, `hash.js`,
`bn.js` (both versions), and their many dependencies.  This also means
there are 33 less dependencies downloaded when running a fresh
`npm install` and will make the project much easier to maintain.

This reduces the bundle size by 44% (82kb minified and gzipped) over
the current 3.0 branch as well as reducing the amount of configuration
required to bundle.

Closes #1814, #1817, #2272, and #2306

Co-authored-by: Caleb Kniffen <ckniffen@ripple.com>
ckniffen added a commit that referenced this issue Nov 30, 2023
@sublimator @ckniffen
feat: use @noble and @Scure libraries for cryptography (#2273)
f1585cf 
Switch to using `@noble/hashes`, `@noble/curves`, `@scure/base`,
`@scure/bip32`, and `@scure/bip39`. This replaces `crypto` polyfills
(such as `crypto-browserify`), `create-hash`, `elliptic`, `hash.js`,
`bn.js` (both versions), and their many dependencies.  This also means
there are 33 less dependencies downloaded when running a fresh
`npm install` and will make the project much easier to maintain.

This reduces the bundle size by 44% (82kb minified and gzipped) over
the current 3.0 branch as well as reducing the amount of configuration
required to bundle.

Closes #1814, #1817, #2272, and #2306

Co-authored-by: Caleb Kniffen <ckniffen@ripple.com>
ckniffen added a commit that referenced this issue Feb 1, 2024
@sublimator @ckniffen
feat: use @noble and @Scure libraries for cryptography (#2273)
217b111 
Switch to using `@noble/hashes`, `@noble/curves`, `@scure/base`,
`@scure/bip32`, and `@scure/bip39`. This replaces `crypto` polyfills
(such as `crypto-browserify`), `create-hash`, `elliptic`, `hash.js`,
`bn.js` (both versions), and their many dependencies.  This also means
there are 33 less dependencies downloaded when running a fresh
`npm install` and will make the project much easier to maintain.

This reduces the bundle size by 44% (82kb minified and gzipped) over
the current 3.0 branch as well as reducing the amount of configuration
required to bundle.

Closes #1814, #1817, #2272, and #2306

Co-authored-by: Caleb Kniffen <ckniffen@ripple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckniffen ckniffen

Labels
3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use noble libs for cryptography sublimator/ripple-lib
2 participants
@ckniffen @sublimator