Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nftoken_id, nftoken_ids and offer_id meta fields into NFT Tx responses #2316

Closed
ckniffen opened this issue May 19, 2023 · 1 comment
Closed

Add nftoken_id, nftoken_ids and offer_id meta fields into NFT Tx responses #2316

ckniffen opened this issue May 19, 2023 · 1 comment
Labels
enhancement good first issue

Comments

@ckniffen
Copy link
Collaborator

ckniffen commented May 19, 2023 •
edited
Loading

NFToken transactions have these meta fields being added to a transactions response in rippled@1.11.0. Typing information needs to be added for them.

See: XRPLF/rippled#4447
tequdev added a commit to tequdev/xrpl.js that referenced this issue Aug 29, 2023
@tequdev
Add nftoken_id, nftoken_ids, offer_id to meta fields
a9790e9 
- fix XRPLF#2316
@tequdev tequdev mentioned this issue Aug 29, 2023
Merged
tequdev added a commit to tequdev/xrpl.js that referenced this issue Aug 29, 2023
@tequdev
Add nftoken_id, nftoken_ids, offer_id to meta fields
ed06e1a 
- fix XRPLF#2316
ckniffen pushed a commit that referenced this issue Sep 1, 2023
@tequdev
Add nftoken_id, nftoken_ids, offer_id to meta fields (#2450)
47b3416 
Add type for metadata for specific transactions(`Payment`, `NFTokenMint`, `NFTokenCreateOffer`, `NFTokenAcceptOffer`, `NFTokenCancelOffer`)

Closes #2316
ckniffen pushed a commit that referenced this issue Sep 1, 2023
@tequdev @ckniffen
Add nftoken_id, nftoken_ids, offer_id to meta fields (#2450)
65a7398 
Add type for metadata for specific transactions(`Payment`, `NFTokenMint`, `NFTokenCreateOffer`, `NFTokenAcceptOffer`, `NFTokenCancelOffer`)

Closes #2316
@JST5000
Copy link
Contributor

JST5000 commented Sep 8, 2023

Closed by #2450

@JST5000 JST5000 closed this as completed Sep 8, 2023
ckniffen pushed a commit that referenced this issue Oct 5, 2023
@tequdev @ckniffen
Add nftoken_id, nftoken_ids, offer_id to meta fields (#2450)
4315bae 
Add type for metadata for specific transactions(`Payment`, `NFTokenMint`, `NFTokenCreateOffer`, `NFTokenAcceptOffer`, `NFTokenCancelOffer`)

Closes #2316
ckniffen pushed a commit that referenced this issue Oct 18, 2023
@tequdev @ckniffen
Add nftoken_id, nftoken_ids, offer_id to meta fields (#2450)
2c04d28 
Add type for metadata for specific transactions(`Payment`, `NFTokenMint`, `NFTokenCreateOffer`, `NFTokenAcceptOffer`, `NFTokenCancelOffer`)

Closes #2316
ckniffen pushed a commit that referenced this issue Oct 25, 2023
@tequdev @ckniffen
Add nftoken_id, nftoken_ids, offer_id to meta fields (#2450)
b5aa70b 
Add type for metadata for specific transactions(`Payment`, `NFTokenMint`, `NFTokenCreateOffer`, `NFTokenAcceptOffer`, `NFTokenCancelOffer`)

Closes #2316
ckniffen pushed a commit that referenced this issue Nov 1, 2023
@tequdev @ckniffen
Add nftoken_id, nftoken_ids, offer_id to meta fields (#2450)
b0a5cfd 
Add type for metadata for specific transactions(`Payment`, `NFTokenMint`, `NFTokenCreateOffer`, `NFTokenAcceptOffer`, `NFTokenCancelOffer`)

Closes #2316
ckniffen pushed a commit that referenced this issue Nov 30, 2023
@tequdev @ckniffen
Add nftoken_id, nftoken_ids, offer_id to meta fields (#2450)
14ad9d8 
Add type for metadata for specific transactions(`Payment`, `NFTokenMint`, `NFTokenCreateOffer`, `NFTokenAcceptOffer`, `NFTokenCancelOffer`)

Closes #2316
ckniffen pushed a commit that referenced this issue Feb 1, 2024
@tequdev @ckniffen
Add nftoken_id, nftoken_ids, offer_id to meta fields (#2450)
83442b1 
Add type for metadata for specific transactions(`Payment`, `NFTokenMint`, `NFTokenCreateOffer`, `NFTokenAcceptOffer`, `NFTokenCancelOffer`)

Closes #2316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ckniffen @JST5000