feat: add support for current sidechain design #2012
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvadari
commented
Jun 1, 2022
Comment on lines
-150
to
+151
| const bytes = this.bytes | ||
| const bytes = Buffer.alloc(this.bytes.length) | ||
| this.bytes.copy(bytes) |
There was a problem hiding this comment.
This fixes a minor issue I ran into, where I wasn't expecting toJSON to modify this.bytes
|
Superseded by #2039 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR adds support for the latest version of the sidechain design. It also removes the helper methods that were used for the previous version, since those are no longer needed.
There are 6 new transaction types:
XChainDoorCreate(creates a new door account)XChainSeqNumCreate(creates a new cross-chain sequence number)XChainTransfer(initiates a cross-chain transfer)XChainClaim(claims the transfer funds on the destination chain)Context of Change
sidechain prod release
Type of Change
Before / After
Test Plan
Tests were added for all the new features. CI passes.
Future Tasks