Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add AMM support #2071

Merged
merged 121 commits into from
Aug 18, 2023
Merged

feat: add AMM support #2071

merged 121 commits into from
Aug 18, 2023

Conversation

khancode
Copy link
Collaborator

@khancode khancode commented Aug 17, 2022 •
edited
Loading

High Level Overview of Change

Adds Automated Market Maker (AMM) support to xrpl.js.

Context of Change

Adds AMM core functionality, referencing the XLS-30 spec.

New transactions added:

  • AMMCreate
  • AMMDeposit
  • AMMWithdraw
  • AMMVote
  • AMMBid
  • AMMDelete

New RPC command:

  • amm_info

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Test Plan

Created unit tests to test the transactions and RPC command models.

@khancode khancode changed the title add AMM support [DO NOT MERGE] add AMM support Aug 20, 2022
@khancode khancode marked this pull request as ready for review August 20, 2022 14:58
@khancode khancode requested a review from mvadari August 1, 2023 17:03
@XRPLF XRPLF deleted a comment from xrpl-grants Aug 4, 2023
@XRPLF XRPLF deleted a comment from xrpl-grants Aug 4, 2023
JST5000
JST5000 approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@JST5000 JST5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Just some comments on the error messages which are likely my ignorance rather than issues.

@intelliot
Copy link
Collaborator

you can update the original PR description to mention AMMDelete

@khancode khancode requested a review from mvadari August 16, 2023 19:24
JST5000
JST5000 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@JST5000 JST5000 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rereviewed and LGTM pending fixing the CI errors (unclear what's causing them)

@khancode khancode merged commit 5581474 into main Aug 18, 2023
17 checks passed
@khancode khancode deleted the amm branch August 18, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckniffen ckniffen ckniffen approved these changes

@JST5000 JST5000 JST5000 approved these changes

@mvadari mvadari mvadari approved these changes

@tequdev tequdev Awaiting requested review from tequdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@khancode @tequdev @intelliot @ckniffen @mvadari @JST5000