Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: run snippets in CI #2345

Merged
merged 6 commits into from
Jun 22, 2023
Merged

test: run snippets in CI #2345

merged 6 commits into from
Jun 22, 2023

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Jun 20, 2023

High Level Overview of Change

Title says it all.

Context of Change

There was an error in the snippets that wasn't caught.

Type of Change

  • Tests (You added tests for code that already exists, or your new feature included in this PR)

Test Plan

CI passes.

@mvadari mvadari changed the title ci: run snippets in CI test: run snippets in CI Jun 20, 2023
@mvadari mvadari marked this pull request as ready for review June 20, 2023 20:01
@mvadari mvadari requested review from JST5000 and pdp2121 June 20, 2023 20:22
JST5000
JST5000 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@JST5000 JST5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvadari mvadari merged commit 6228f91 into main Jun 22, 2023
@mvadari mvadari deleted the ci-snippets branch June 22, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdp2121 pdp2121 pdp2121 approved these changes

@JST5000 JST5000 JST5000 approved these changes

@justinr1234 justinr1234 justinr1234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvadari @justinr1234 @JST5000 @pdp2121