Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ledger entry types for NFTokens #2349

Merged
merged 5 commits into from
Jun 26, 2023
Merged

feat: add ledger entry types for NFTokens #2349

merged 5 commits into from
Jun 26, 2023

Conversation

ckniffen
Copy link
Collaborator

High Level Overview of Change

Add NFToken, NFTokenPage, and NFTokenOffer types.

Type of Change

  • New feature (non-breaking change which adds functionality)

@ckniffen
feat: add ledger entry types for NFTokens
10eb8e4 
Add `NFToken`, `NFTokenPage`, and `NFTokenOffer`
JST5000
JST5000 approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@JST5000 JST5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ckniffen and others added 2 commits June 26, 2023 12:24
@ckniffen @JST5000
Add a an
7e73fd4 
Co-authored-by: Jackson Mills <jmills@ripple.com>
@ckniffen
Merge branch 'main' into feature/nft-ledger-object-types
de4485f
@ckniffen ckniffen merged commit b152ebc into main Jun 26, 2023
@ckniffen ckniffen deleted the feature/nft-ledger-object-types branch June 26, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JST5000 JST5000 JST5000 approved these changes

@justinr1234 justinr1234 justinr1234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckniffen @justinr1234 @JST5000