-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix docs broken link #2369
fix docs broken link #2369
Conversation
<li><a href="./UNIQUE_SETUPS.md#using-xrpljs-with-react-native">Using xrpl.js with <code>React Native</code></a></li> | ||
<li><a href="./UNIQUE_SETUPS.md#using-xrpljs-with-vite-react">Using xrpl.js with <code>Vite React</code></a></li> | ||
<li><a href="./UNIQUE_SETUPS.md#using-xrpljs-with-deno">Using xrpl.js with <code>Deno</code></a></li> | ||
<li><a href="https://github.com/XRPLF/xrpl.js/blob/main/UNIQUE_SETUPS.md#using-xrpljs-from-a-cdn">Using xrpl.js with a CDN</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way in typedoc to populate urls? This approach will not link properly for branches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the problem is that the docs don't generate separate pages for github pages, I'll look into the typedoc again and find a solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is the right place to fix the links. Isn't docs/index.html
generated by TypeDoc?
the problem is that the docs don't generate separate pages for github pages (so the relative url before would go to 404), I'll look into the typedoc again and find a solution |
It is created from typedoc from the README. There are several issues opened for this with typedoc. What it comes down to is typedoc cannot generate markdown except for the index. One solution is to use docusaurus and its typedoc plugin that will generate the api pages in typedoc and all other documention is generated from markdown files. |
High Level Overview of Change
The docs site js.xrpl.org has broken links for Case by Case Setup Steps, this PR fixes it