fix: escrow finish and cancel integration #2382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanlei
approved these changes
Jul 13, 2023
ckniffen
approved these changes
Jul 14, 2023
mvadari
reviewed
Jul 17, 2023
| * console.error(error); | ||
| * } | ||
| */ | ||
| export async function waitForAndForceProgressLedgerTime( |
There was a problem hiding this comment.
This function is only used in the escrow tests, right?
ckniffen
added a commit
that referenced
this pull request
Jul 25, 2023
* fix: escrow finish and cancel integration (#2382) * fix: escrow finish and cancel integration * add docs * Update docker to xrpllabsofficial/xrpld:1.12.0-b1 (#2381) * release 2.9.1 (#2391) * build(deps-dev): bump word-wrap from 1.2.3 to 1.2.4 (#2392) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: add Clawback amendment support (#2353) * Add Clawback transaction * Account flag lsfAllowTrustLineClawback * Support bitwise flag checking of 64 bit flags * build(deps-dev): bump ts-jest from 29.1.0 to 29.1.1 (#2396) * build(deps-dev): bump ts-loader from 9.4.2 to 9.4.4 (#2395) Bumps [ts-loader](https://github.com/TypeStrong/ts-loader) from 9.4.2 to 9.4.4. - [Release notes](https://github.com/TypeStrong/ts-loader/releases) - [Changelog](https://github.com/TypeStrong/ts-loader/blob/main/CHANGELOG.md) - [Commits](TypeStrong/ts-loader@v9.4.2...v9.4.4) --- updated-dependencies: - dependency-name: ts-loader dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump source-map-loader from 3.0.2 to 4.0.1 (#2399) * build(deps-dev): bump url from 0.11.0 to 0.11.1 (#2400) Bumps [url](https://github.com/defunctzombie/node-url) from 0.11.0 to 0.11.1. - [Commits](defunctzombie/node-url@v0.11.0...v0.11.1) --- updated-dependencies: - dependency-name: url dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump jest and @types/jest (#2397) Bumps [jest](https://github.com/facebook/jest/tree/HEAD/packages/jest) and [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest). These dependencies needed to be updated together. Updates `jest` from 29.5.0 to 29.6.1 - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/jestjs/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/jest/commits/v29.6.1/packages/jest) Updates `@types/jest` from 29.5.1 to 29.5.3 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) --- updated-dependencies: - dependency-name: jest dependency-type: direct:development update-type: version-update:semver-minor - dependency-name: "@types/jest" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Caleb Kniffen <ckniffen@ripple.com> * chore: remove extra lock files and `nyc` (#2403) nyc is not a direct dependency any more and nested lock files are unused --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: justinr1234 <justinr1234@gmail.com> Co-authored-by: Shawn Xie <35279399+shawnxie999@users.noreply.github.com> Co-authored-by: pdp2121 <71317875+pdp2121@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
Test Plan