feat(deps): remove assert-browserify
#2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `if` statements and manually error throwing to save 21kb gzipped.
mvadari
approved these changes
Jul 18, 2023
Yeah I just wanted theses big dependencies changes to go with others so people can edit their bundler configs in one swoop. |
khancode
approved these changes
Jul 26, 2023
ckniffen
added a commit
that referenced
this pull request
Aug 12, 2023
Use if statements and manually error throwing to save 20kb gzipped. BREAKING CHANGE: If you were catching AssertionError you need to change to Error.
ckniffen
added a commit
that referenced
this pull request
Aug 15, 2023
Use if statements and manually error throwing to save 20kb gzipped. BREAKING CHANGE: If you were catching AssertionError you need to change to Error.
ckniffen
added a commit
that referenced
this pull request
Aug 28, 2023
Use if statements and manually error throwing to save 20kb gzipped. BREAKING CHANGE: If you were catching AssertionError you need to change to Error.
ckniffen
added a commit
that referenced
this pull request
Aug 28, 2023
Use if statements and manually error throwing to save 20kb gzipped. BREAKING CHANGE: If you were catching AssertionError you need to change to Error.
ckniffen
added a commit
that referenced
this pull request
Sep 1, 2023
Use if statements and manually error throwing to save 20kb gzipped. BREAKING CHANGE: If you were catching AssertionError you need to change to Error.
ckniffen
added a commit
that referenced
this pull request
Oct 5, 2023
Use if statements and manually error throwing to save 20kb gzipped. BREAKING CHANGE: If you were catching AssertionError you need to change to Error.
ckniffen
added a commit
that referenced
this pull request
Oct 18, 2023
Use if statements and manually error throwing to save 20kb gzipped. BREAKING CHANGE: If you were catching AssertionError you need to change to Error.
ckniffen
added a commit
that referenced
this pull request
Oct 25, 2023
Use if statements and manually error throwing to save 20kb gzipped. BREAKING CHANGE: If you were catching AssertionError you need to change to Error.
ckniffen
added a commit
that referenced
this pull request
Nov 1, 2023
Use if statements and manually error throwing to save 20kb gzipped. BREAKING CHANGE: If you were catching AssertionError you need to change to Error.
ckniffen
added a commit
that referenced
this pull request
Nov 30, 2023
Use if statements and manually error throwing to save 20kb gzipped. BREAKING CHANGE: If you were catching AssertionError you need to change to Error.
ckniffen
added a commit
that referenced
this pull request
Feb 1, 2024
Use if statements and manually error throwing to save 20kb gzipped. BREAKING CHANGE: If you were catching AssertionError you need to change to Error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Use
ifstatements and manually error throwing to save 20kb gzipped.BREAKING CHANGE: If you were catching
AssertionErroryou need to change toError.Type of Change
Future Tasks
Would be nice to have more descriptive error messages. Most of the assertions had no messages.