test: remove extra polyfills only for testing #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the testing polyfills by using jasmine and not jest in the browser. We were already using jasmine but where overriding those methods with jest versions which was not needed. The previous karma setup also used a single entrypoint which meant that not all integration tests were running because all files were not imported in integrations/index.ts. This also eliminates 50 dev dependencies.
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: @geut/browser-node-core@2.0.13, browserify-fs@1.0.0, constants-browserify@1.0.0, ejs@3.1.9, https-browserify@1.0.0, node-polyfill-webpack-plugin@2.0.1 |
ckniffen
commented
Aug 8, 2023
| @@ -33,9 +33,6 @@ | |||
| "devDependencies": { | |||
| "@geut/browser-node-core": "^2.0.13", | |||
| "@types/node": "^16.18.38", | |||
| "browserify-fs": "^1.0.0", | |||
There was a problem hiding this comment.
Hopefully soon we can eliminate node-polyfill-webpack-plugin which will remove even more dependencies from package-lock.json
There was a problem hiding this comment.
actually we can get rid of node-polyfill-webpack-plugin now. Will eliminate 22 more deps.
JST5000
reviewed
Aug 8, 2023
JST5000
reviewed
Aug 9, 2023
|
|
||
| // Ensure you export all added tests above "export * from './finalTest'", otherwise they will not be run. | ||
| export * from './finalTest.test' | ||
| /* eslint-disable import/unambiguous -- silence is golden */ |
There was a problem hiding this comment.
If the file is empty, why does it need to exist?
There was a problem hiding this comment.
If it wasnt empty it errored and the webpack needed an entry point. Might be worth investigating why that causes problems
32 tasks
ckniffen
added a commit
to sublimator/ripple-lib
that referenced
this pull request
Aug 10, 2023
…r path Turns out `stream-browserify` cant be removed till XRPLF#2428 goes into effect.
jonathanlei
approved these changes
Aug 12, 2023
ckniffen
added a commit
that referenced
this pull request
Aug 12, 2023
Removes the testing polyfills by using jasmine and not jest in the browser. We were already using jasmine but where overriding those methods with jest versions which was not needed. The previous karma setup also used a single entrypoint which meant that not all integration tests were running because all files were not imported in integrations/index.ts. This also eliminates 79 dev dependencies.
ckniffen
added a commit
to sublimator/ripple-lib
that referenced
this pull request
Aug 12, 2023
stream-browserify last dependencies removed by XRPLF#2428 and this branch moving to noble libs.
ckniffen
added a commit
that referenced
this pull request
Aug 15, 2023
Removes the testing polyfills by using jasmine and not jest in the browser. We were already using jasmine but where overriding those methods with jest versions which was not needed. The previous karma setup also used a single entrypoint which meant that not all integration tests were running because all files were not imported in integrations/index.ts. This also eliminates 79 dev dependencies.
ckniffen
added a commit
that referenced
this pull request
Aug 28, 2023
Removes the testing polyfills by using jasmine and not jest in the browser. We were already using jasmine but where overriding those methods with jest versions which was not needed. The previous karma setup also used a single entrypoint which meant that not all integration tests were running because all files were not imported in integrations/index.ts. This also eliminates 79 dev dependencies.
ckniffen
added a commit
that referenced
this pull request
Aug 28, 2023
Removes the testing polyfills by using jasmine and not jest in the browser. We were already using jasmine but where overriding those methods with jest versions which was not needed. The previous karma setup also used a single entrypoint which meant that not all integration tests were running because all files were not imported in integrations/index.ts. This also eliminates 79 dev dependencies.
ckniffen
added a commit
that referenced
this pull request
Sep 1, 2023
Removes the testing polyfills by using jasmine and not jest in the browser. We were already using jasmine but where overriding those methods with jest versions which was not needed. The previous karma setup also used a single entrypoint which meant that not all integration tests were running because all files were not imported in integrations/index.ts. This also eliminates 79 dev dependencies.
ckniffen
added a commit
that referenced
this pull request
Oct 5, 2023
Removes the testing polyfills by using jasmine and not jest in the browser. We were already using jasmine but where overriding those methods with jest versions which was not needed. The previous karma setup also used a single entrypoint which meant that not all integration tests were running because all files were not imported in integrations/index.ts. This also eliminates 79 dev dependencies.
ckniffen
added a commit
that referenced
this pull request
Oct 18, 2023
Removes the testing polyfills by using jasmine and not jest in the browser. We were already using jasmine but where overriding those methods with jest versions which was not needed. The previous karma setup also used a single entrypoint which meant that not all integration tests were running because all files were not imported in integrations/index.ts. This also eliminates 79 dev dependencies.
ckniffen
added a commit
that referenced
this pull request
Oct 25, 2023
Removes the testing polyfills by using jasmine and not jest in the browser. We were already using jasmine but where overriding those methods with jest versions which was not needed. The previous karma setup also used a single entrypoint which meant that not all integration tests were running because all files were not imported in integrations/index.ts. This also eliminates 79 dev dependencies.
ckniffen
added a commit
that referenced
this pull request
Nov 1, 2023
Removes the testing polyfills by using jasmine and not jest in the browser. We were already using jasmine but where overriding those methods with jest versions which was not needed. The previous karma setup also used a single entrypoint which meant that not all integration tests were running because all files were not imported in integrations/index.ts. This also eliminates 79 dev dependencies.
ckniffen
added a commit
that referenced
this pull request
Nov 30, 2023
Removes the testing polyfills by using jasmine and not jest in the browser. We were already using jasmine but where overriding those methods with jest versions which was not needed. The previous karma setup also used a single entrypoint which meant that not all integration tests were running because all files were not imported in integrations/index.ts. This also eliminates 79 dev dependencies.
ckniffen
added a commit
that referenced
this pull request
Feb 1, 2024
Removes the testing polyfills by using jasmine and not jest in the browser. We were already using jasmine but where overriding those methods with jest versions which was not needed. The previous karma setup also used a single entrypoint which meant that not all integration tests were running because all files were not imported in integrations/index.ts. This also eliminates 79 dev dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Removes the testing polyfills by using jasmine and not jest in the browser. We were already using jasmine but where overriding those methods with jest versions which was not needed.
The previous karma setup also used a single entrypoint which meant that not all integration tests were running because all files were not imported in integrations/index.ts.
This also eliminates 79 dev dependencies.
Type of Change
Future Work
xrplunit tests in browser