ci: Add a script to generate changes to ci-config #2431
Conversation
.ci-config/rippled.cfg
Outdated
| # Added August 9th, 2023 | ||
| 86E83A7D2ECE3AD5FA87AB2195AE015C950469ABF0B72EAACED318F74886AE90 CryptoConditionsSuite | ||
| AE35ABDEFBDE520372B31C957020B34A7A4A9DC3115A69803A44016477C84D6E fixNFTokenRemint | ||
| B2A4DB846F0891BF2C76AB2F2ACC8F5B4EC64437135C6E56F3F859DE5FFD5856 ExpandedSignerList |
There was a problem hiding this comment.
Should probably be added above since it was much older. Added in 1.9.1.
There was a problem hiding this comment.
Might need to add an integration test for WalletLocator and the size of SignerLists
There was a problem hiding this comment.
Would it be alright to leave that for a separate PR? (I'm not exactly sure what we'd be testing for that - maybe you can flesh out an Issue to add it w/ an idea for what we'd want to test on the client library side?)
…to automate-config
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ### Added | |||
| * Updated to include latest updates to `definitions.json` including changes for the `fixNFTokenRemint` amendment. | |||
There was a problem hiding this comment.
nit: note that this includes AMM definitions updates too.
There was a problem hiding this comment.
Shouldn't the AMM definitions wait for the AMM PR instead of being done here?
There was a problem hiding this comment.
I'd prefer to just match rippled's develop as best as possible instead of manually editing the definitions.json file after running the script. Plus, I don't think there's any harm in having more definitions available.
There was a problem hiding this comment.
Can we hold off on this PR until that's merged in, then? Since that one's going to be merged soon anyways.
There was a problem hiding this comment.
This was generated from develop already - not sure why the definitions were there before the big AMM PR, but it seems they're already defined.
|
super nit: could the PR title avoid the word "automate"? That's part of the reason why I asked about a GitHub Action - I was expecting something that automatically ran the script. |
JST5000
changed the title
I think I wanted to automate it originally, but didn't see an easy way - I think your question was fair, I just didn't find an answer just yet and might look into it more as a follow up task. Updated the title for now since I think the changes are helpful as is. |
High Level Overview of Change
Automate figuring out which amendments to enable in our CI docker container.
Context of Change
Periodically we need to update the
rippled.cfgwe use in the standalone node we use during CI so that the library is being tested against the latest amendments. This adds a script to get the hashes of any new amendments so it's easy to update our CI without a bunch of manual lookups / comparisons.Type of Change
Test Plan
Manually tested the script against various networks / removing entries from the config file to see if it noticed.
Future Tasks
Automatically generate a PR to update the CI file directly with hashes + names instead of requiring a manual lookup on the known amendments page.