Re-add the walletFromSecretNumbers custom algorithm test
#2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanlei
approved these changes
Aug 17, 2023
ckniffen
approved these changes
Aug 17, 2023
ckniffen
pushed a commit
that referenced
this pull request
Aug 28, 2023
ckniffen
pushed a commit
that referenced
this pull request
Aug 28, 2023
ckniffen
pushed a commit
that referenced
this pull request
Sep 1, 2023
ckniffen
pushed a commit
that referenced
this pull request
Oct 5, 2023
ckniffen
pushed a commit
that referenced
this pull request
Oct 18, 2023
ckniffen
pushed a commit
that referenced
this pull request
Oct 25, 2023
ckniffen
pushed a commit
that referenced
this pull request
Nov 1, 2023
ckniffen
pushed a commit
that referenced
this pull request
Nov 30, 2023
ckniffen
pushed a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Adds a test for using ED25519 as a custom algorithm to
walletFromSecretNumbersContext of Change
Now that the underlying issue is fixed allowing users to specify which algorithm they want, we can re-add this test.
Type of Change
Test Plan
CI Passes