-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rippled API v2 support and use as default #2656
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khancode
changed the title
add apiVersion support to requests and AccountInfoResponse v1/v2 types
Add support for rippled apiVersion requests and AccountInfoResponse v1/v2 types
Mar 11, 2024
khancode
changed the title
Add support for rippled apiVersion requests and AccountInfoResponse v1/v2 types
Add support for rippled apiVersion requests and AccountInfoResponse type
Mar 25, 2024
khancode
changed the title
Add support for rippled apiVersion requests and AccountInfoResponse type
Add rippled apiVersion support for requests and AccountInfoResponse type
Mar 25, 2024
khancode
changed the title
Add rippled apiVersion support for requests and AccountInfoResponse type
feat: add rippled apiVersion support for requests and AccountInfoResponse type
Mar 25, 2024
khancode
changed the title
feat: add rippled apiVersion support for requests and AccountInfoResponse type
feat: add rippled api_version support for requests and AccountInfoResponse type
Mar 27, 2024
khancode
changed the title
feat: add rippled api_version support for requests and AccountInfoResponse type
feat: add rippled api_version support for v2 requests and AccountInfoResponse type
Mar 27, 2024
ckniffen
reviewed
Apr 1, 2024
packages/xrpl/test/integration/transactions/signerListSet.test.ts
Outdated
Show resolved
Hide resolved
This reverts commit 89794c6.
ckeshava
approved these changes
Jun 24, 2024
justinr1234
reviewed
Jun 24, 2024
justinr1234
reviewed
Jun 27, 2024
justinr1234
reviewed
Jun 27, 2024
justinr1234
reviewed
Jun 27, 2024
justinr1234
reviewed
Jun 27, 2024
justinr1234
reviewed
Jun 27, 2024
justinr1234
reviewed
Jun 27, 2024
justinr1234
reviewed
Jun 27, 2024
justinr1234
reviewed
Jun 27, 2024
justinr1234
reviewed
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- For all your tests, shouldn't we be keeping v1 tests? I know you added some v1 tests, but you changed a lot of tests to use
tx_json
but I didn't see tests for making sure v1 still works - I think we should add a warning to people when they're trying to access v1 data but the library is defaulting to v2 -- Likely we can use a class getter than throws an error when they try to access the wrong
tx
ortx_json
|
justinr1234
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Add rippled
api_version
support for v2 and use as default while maintaining support for v1.Context of Change
api_version
2 is supported by 100% of rippled servers now that numerous v2 amendments have activated. (as of April 8, 2024.). Therefore, we should default to using v2 and maintain support of v1 response types.Type of Change
Did you update HISTORY.md?
Test Plan
Updated existing unit/integ tests and added new ones.