-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove bridge snippet test, the sidechain has been shut down #2773
Conversation
… test, remove dependence on theexternal state of testnet
@CodeRabbit full review |
@coderabbitai full review |
Actions performedFull review triggered. |
WalkthroughThe pull request introduces significant changes to the XRPL codebase, including the removal of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
) * update Paths snippet test: perform prerequisite test setup within the test, remove dependence on theexternal state of testnet * remove bridge snippet test, the sidechain has been shut down * [FIX] Update paths snippet. Replace RipplePathFind with PathFind RPC (fixes XRPLF#2385)
High Level Overview of Change
The sidechain devnet (https://sidechain-net2.devnet.rippletest.net:51234/) has been shutdown. This PR removes the snippet pertaining to XChainBridge examples.
The CI/CD pipeline has been failing with errors. Here's an example: https://github.com/XRPLF/xrpl-py/actions/runs/10410149343/job/29898229766#step:8:168
Context of Change
Type of Change
Did you update HISTORY.md?
Test Plan
Summary by CodeRabbit
New Features
Bug Fixes
Documentation