Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features not toggleable in config? #22

Closed
brphelps opened this issue Aug 10, 2021 · 1 comment · Fixed by #26
Closed

Features not toggleable in config? #22

brphelps opened this issue Aug 10, 2021 · 1 comment · Fixed by #26
Labels
enhancement New feature or request

Comments

@brphelps
Copy link

Problem Statement

I see a list of features (some described as on by default) -- I'm trying to disable all features that write out the full query text of the executed query. Is there a way I can currently do that?

Proposed Solution

SpanOptions or something like it would support a "WriteQueryStatement" arg.

Alternatives

It seems like there is a way to configure some things, maybe I am overlooking how to disable these other spans?

@brphelps brphelps added the enhancement New feature or request label Aug 10, 2021
@XSAM
Copy link
Owner

XSAM commented Aug 14, 2021

Sorry about the confusing description of "Enabled by default", which actually means it is a feature that can't be disabled. I can fix that confusing description in the next updates.

Interestingly, the OpenTelemetry Specification is now claiming the db.statement is not a required attribute anymore.

I can try to add an option, maybe called Query, to disable this feature. That will stop populating the db.statement attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants