-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpanOption DisableQuery #26
Conversation
DisableQuery when set to true, will suppress attribute of key db.statement on spans.
this commit adds a step check on every span which uses db.statement attribute. in case SpanOption.DisableQuery is set true, the attribute is not set.
Hi @XSAM this time I am trying to disable the query itself. I wonder if would make sense to set the value with something like "-" instead of not sending it. wdyt ? |
I think not sending the value is make sense to me. You can check the example value from the specification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Please update CHANGELOG.md
and run make precommit
before commit.
updates the changelog adding new feature option for SpanOption + fix linting.
Codecov Report
@@ Coverage Diff @@
## main #26 +/- ##
=======================================
- Coverage 82.3% 81.6% -0.8%
=======================================
Files 11 11
Lines 311 299 -12
=======================================
- Hits 256 244 -12
Misses 45 45
Partials 10 10
Continue to review full report at Codecov.
|
Co-authored-by: Sam Xie <xsambundy@gmail.com>
Co-authored-by: Sam Xie <xsambundy@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wesleyvicthor LGTM. Thanks for your contribution.
Hi, this PR attempts to cover the DisableQuery functionality, this time as opposed #25, it makes only the attribute not set.
It tries to cover the expected functionality by #22