Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unnecessary if #3413

Merged
merged 2 commits into from
Jun 3, 2024
Merged

chore: Remove unnecessary if #3413

merged 2 commits into from
Jun 3, 2024

Conversation

AsenHu
Copy link
Contributor

@AsenHu AsenHu commented Jun 3, 2024

No description provided.

@Fangliding
Copy link
Member

Fangliding commented Jun 3, 2024

How does this lead to leaking? It seems to cause some loops (if the client keeps sending request), but other situations seem to be the same, such as incorrect host

@AsenHu
Copy link
Contributor Author

AsenHu commented Jun 3, 2024

How does this lead to leaking?

This was my mistake. Because it's impossible for if to be true, it won't lead to leaking.

@AsenHu AsenHu changed the title Fix: possible memory leak chore: Remove unnecessary if Jun 3, 2024
@Fangliding
Copy link
Member

So keep it consistent with websocket

@Fangliding Fangliding merged commit 4595043 into XTLS:main Jun 3, 2024
Fangliding pushed a commit to Fangliding/Xray-core that referenced this pull request Jun 5, 2024
CI: not create zip file when not releasing

Makefile: remove unneccesary `install` target &

Add build to `.PHONY` target
Fangliding pushed a commit to Fangliding/Xray-core that referenced this pull request Jun 5, 2024
CI: not create zip file when not releasing

Makefile: remove unneccesary `install` target &

Add build to `.PHONY` target
leninalive pushed a commit to amnezia-vpn/amnezia-xray-core that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants