Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary sleep from test #3600

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Remove unnecessary sleep from test #3600

merged 1 commit into from
Jul 27, 2024

Conversation

mmmray
Copy link
Collaborator

@mmmray mmmray commented Jul 26, 2024

These were copypasted to splithttp tests and then removed there

I can't imagine what they were supposed to do, the tests run fine without

These were copypasted to splithttp tests and then removed there

I can't imagine what they were supposed to do, the tests run fine
without
@Fangliding
Copy link
Member

It appears to be a legacy part, where wstest used gofunc and returned a failure after 5 seconds(timeout)
Later, this mechanism was removed, but this line of code was retained, so it looks confusing

@RPRX RPRX merged commit 7cf5ee8 into XTLS:main Jul 27, 2024
36 checks passed
@mmmray mmmray deleted the test-sleep branch July 27, 2024 14:20
leninalive pushed a commit to amnezia-vpn/amnezia-xray-core that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants