Fix XTLS#116 This issue does not appear at all if mux.cool is disabled. Maybe the issue can be avoided if routing is disabled too, but it's possible that the same issue appears elsewhere. Tests should be added. ***The mux server has no tests at all!*** Step-by-step: 1. The mux server is calling handleStatusNew with the same context multiple times. That function then calls w.dispatcher.Dispatch 2. Dispatch assigns some values specific to the connection onto the outbound here: https://github.com/XTLS/Xray-core/blob/83eef6bc1f554be84aeb799417688a070cd32ab8/app/dispatcher/default.go#L241-L242 3. Because the outbounds array on the connection object is the same across multiple connections (it's the same context), the value of outbound.Target flips back and forth between values such as "1.1.1.1" or "chat.facebook.com" (IPAddress vs DomainAddress) 4. Many layers deeper in routing, as part of this Dispatch call, this function is called: https://github.com/XTLS/Xray-core/blob/83eef6bc1f554be84aeb799417688a070cd32ab8/features/routing/session/context.go#L53-L55 It does two things, in order: 1. Checks if Target is an IPAddress (IsIP) 2. If it's an IP, call IP() Because Target keeps mutating back and forth between multiple kinds of address, it sometimes is an IP for Step 1, and a DomainAddress for Step 2 5. Calling IP() on a DomainAddress panics: panic: Calling IP() on a DomainAddress. goroutine 123018 [running]: github.com/xtls/xray-core/common/net.domainAddress.IP(...) github.com/xtls/xray-core/common/net/address.go:172 github.com/xtls/xray-core/features/routing/session.(*Context).GetTargetIPs(0xc004175428) github.com/xtls/xray-core/features/routing/session/context.go:54 +0x5f github.com/xtls/xray-core/app/router.(*MultiGeoIPMatcher).Apply(0xc0003a63e0, {0x156c770?, 0xc004175428?}) github.com/xtls/xray-core/app/router/condition.go:143 +0x3e github.com/xtls/xray-core/app/router.(*ConditionChan).Apply(0x495c9d?, {0x156c770, 0xc004175428}) github.com/xtls/xray-core/app/router/condition.go:32 +0x5c github.com/xtls/xray-core/app/router.(*Rule).Apply(...) github.com/xtls/xray-core/app/router/config.go:30 github.com/xtls/xray-core/app/router.(*Router).pickRouteInternal(0xc000367a40, {0x156c770, 0xc004175428}) github.com/xtls/xray-core/app/router/router.go:196 +0x176 github.com/xtls/xray-core/app/router.(*Router).PickRoute(0x1562810?, {0x156c770?, 0xc004175428?}) github.com/xtls/xray-core/app/router/router.go:84 +0x25 github.com/xtls/xray-core/app/dispatcher.(*DefaultDispatcher).routedDispatch(0xc000398fc0, {0x1562810, 0xc0050cd350}, 0xc00418dea0, {{0x15625a8, 0xc005974c10}, 0x1bb, 0x2}) github.com/xtls/xray-core/app/dispatcher/default.go:420 +0x307 created by github.com/xtls/xray-core/app/dispatcher.(*DefaultDispatcher).Dispatch in goroutine 123015 github.com/xtls/xray-core/app/dispatcher/default.go:252 +0x56c

Commits

Commits on Aug 22, 2024

Fix data leak between mux.cool connections

Commits on Aug 24, 2024

add test