This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Make vscode-apielements almost usable #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 8, 2016 18:49
XVincentX
force-pushed
the
XVincentX/goToSymbol
branch
from
be4d5e3
to
4c58b3f
Compare
XVincentX
changed the title
XVincentX
force-pushed
the
XVincentX/goToSymbol
branch
from
4c58b3f
to
d096902
Compare
XVincentX
force-pushed
the
XVincentX/goToSymbol
branch
14 times, most recently
from
c5117f2
to
50bdd62
Compare
XVincentX
force-pushed
the
XVincentX/goToSymbol
branch
from
50bdd62
to
94d18c4
Compare
| let sourceMap = lodash.get(queryResult, 'attributes.sourceMap', | ||
| lodash.get(queryResult, 'meta.title.attributes.sourceMap', | ||
| lodash.get(queryResult, 'attributes.href.attributes.sourceMap', | ||
| lodash.get(queryResult, 'content[0].attributes.method.attributes.sourceMap') |
There was a problem hiding this comment.
Just a note, in looking at this, I think that all four of these get functions will be executed each time.
There was a problem hiding this comment.
That's right.
Consider this as a wonky method...which works.
The idea would then be to modify drafter to include sourcemaps where missing or use again refract-query to get the nearest source map reference.
Does that make sense?
XVincentX
force-pushed
the
XVincentX/goToSymbol
branch
from
591f779
to
347947e
Compare
XVincentX
changed the title
XVincentX
force-pushed
the
XVincentX/goToSymbol
branch
from
48baf40
to
fbd9568
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make this extension worth to be deployed and announced.
Looking forward!