Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 10 support on macOS #3

Merged
merged 12 commits into from
Jan 12, 2019
Merged

Xcode 10 support on macOS #3

merged 12 commits into from
Jan 12, 2019

Conversation

dcaravana
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jan 5, 2019

Coverage Status

Coverage remained the same at 95.455% when pulling 7ca125c on CrowdEmotion:master into 231a3b5 on XadillaX:master.

@XadillaX
Copy link
Owner

XadillaX commented Jan 5, 2019

Well done!

Would you please add a test environment about your changes in .travis.yml? Thx

@XadillaX
Copy link
Owner

XadillaX commented Jan 5, 2019

BTW, I can install this package under macOS. What is this PR mainly for?

$ npm install mp4duration

✔ Installed 1 packages
  CXX(target) Release/obj.target/mp4duration/src/mp4duration.o
  CXX(target) Release/obj.target/mp4duration/src/parse.o
  SOLINK_MODULE(target) Release/mp4duration.node
✔ Run 1 scripts
✔ All packages installed (2 packages installed from npm registry, used 5s(network 1s), speed 370.93kB/s, json 2(4.89kB), tarball 378.29kB)

@dcaravana
Copy link
Contributor Author

This is a fix for Xcode 10, see nodejs/node-gyp#469.

Is Xcode 10 installed on your Mac? That would explain why you managed to install the module.

I'll add the environment next.

@dcaravana
Copy link
Contributor Author

Finally managed to configure Travis... Apologies for the many tries but I got confused by the many sources of discording fixes and the non-linear support for env matrix.
Still not perfect but it's testing what we need to test.

@XadillaX XadillaX merged commit a071b77 into XadillaX:master Jan 12, 2019
@XadillaX
Copy link
Owner

1.0.0 released.

@XadillaX XadillaX self-requested a review January 12, 2019 10:05
@XadillaX XadillaX self-assigned this Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants