Fix governance vote purge

[tequdev]

High Level Overview of Change

Fixed previous_member and vote_key are set correctly when deleting votes in Governance Hook.

Context of Change

• fix Governance hook: Votes of removed members are not purged #211

The implementation didn't match the top comment in the govern.c file.

• L1/L2 information was missing when obtaining State.

Fixed existence comparison conditions.

Type of Change

• [x ] Bug fix (non-breaking change which fixes an issue)

If each governance table continues to use this governance Hook, it is recommended that the Hook be updated.

Test Plan

Since the author is not familiar with C++ code and cannot write sufficient test code, so used JS for the test instead.

https://github.com/tequdev/xahau-governance-hook-test

[RichardAH]

I think this is correct but we really need a deterministic build setup for these "embedded" hooks so we can prove what the wasm binary contains. Not that I don't trust @tequdev, but because no one should have to trust an opaque binary to begin with. I feel uncomfortable about merging opaque binaries, even ones I generate myself.

[dangell7]

I think this is correct but we really need a deterministic build setup for these "embedded" hooks so we can prove what the wasm binary contains. Not that I don't trust @tequdev, but because no one should have to trust an opaque binary to begin with. I feel uncomfortable about merging opaque binaries, even ones I generate myself.

So you want to build and store the hex binary in the repo during the git actions? We could also do it how you did the tests where it shows both the c and the hex?

https://raw.githubusercontent.com/Xahau/xahaud/refs/heads/dev/src/test/app/SetHook_wasm.h

[RichardAH]

I think this is correct but we really need a deterministic build setup for these "embedded" hooks so we can prove what the wasm binary contains. Not that I don't trust @tequdev, but because no one should have to trust an opaque binary to begin with. I feel uncomfortable about merging opaque binaries, even ones I generate myself.

So you want to build and store the hex binary in the repo during the git actions? We could also do it how you did the tests where it shows both the c and the hex?

https://raw.githubusercontent.com/Xahau/xahaud/refs/heads/dev/src/test/app/SetHook_wasm.h

Yeah I think automated building of the blobs during the git actions is the correct answer. But they have to be deterministic builds.