Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remarks amendment #301

Open
wants to merge 33 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
7efc26a
initial version of remarks
RichardAH Mar 25, 2024
8522c66
transactor
RichardAH Mar 25, 2024
24ac5d5
bug fixes, but levelisation issues
RichardAH Mar 25, 2024
349f4d2
reorder cmake
dangell7 Mar 25, 2024
01e7caa
fix applyHook headers
dangell7 Mar 25, 2024
4e10d7d
fix applySteps headers
dangell7 Mar 25, 2024
533ba7a
nit: remit headerfile
dangell7 Mar 25, 2024
9edf7ae
create SetRemarks header
dangell7 Mar 25, 2024
fdf02a3
Update SetRemarks.cpp
dangell7 Mar 25, 2024
63b0245
fix muldiv
dangell7 Mar 25, 2024
6d496cc
create set remarks test
dangell7 Mar 25, 2024
89bcacc
use sandbox and peak
dangell7 Mar 25, 2024
2adc234
Update SetRemarks_test.cpp
dangell7 Mar 25, 2024
36ff484
Revert "fix muldiv"
dangell7 Mar 25, 2024
f40621c
Update mulDiv.cpp
dangell7 Mar 25, 2024
b1447af
refactor, feature enable check
RichardAH Mar 27, 2024
d268638
whoops
RichardAH Mar 27, 2024
f4fe7b7
add jtx helper
dangell7 Apr 2, 2024
4392342
update error warning
dangell7 Apr 2, 2024
3e926c9
add remark fee
dangell7 Apr 2, 2024
a3d61c0
make sfRemarkValue Optional
dangell7 Apr 2, 2024
798212f
add tests
dangell7 Apr 2, 2024
96bb67b
clang-format
dangell7 Apr 2, 2024
bdc59ac
apply sandbox and fixup
dangell7 Apr 3, 2024
519ab34
add more tests
dangell7 Apr 3, 2024
23d49d0
Merge branch 'dev' into remarks
dangell7 May 23, 2024
caffeea
Merge branch 'dev' into remarks
dangell7 Jul 8, 2024
eaec084
Merge branch 'dev' into remarks
dangell7 Sep 19, 2024
a8a4774
add tests
dangell7 Sep 19, 2024
6fb8fef
clang-format
dangell7 Sep 19, 2024
d92403c
Merge branch 'dev' into remarks
RichardAH Nov 9, 2024
a5e2fd0
Merge branch 'dev' into remarks
RichardAH Nov 9, 2024
987247d
Merge branch 'dev' into remarks
RichardAH Nov 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Builds/CMake/RippledCore.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,7 @@ target_sources (rippled PRIVATE
src/ripple/app/tx/impl/Import.cpp
src/ripple/app/tx/impl/Invoke.cpp
src/ripple/app/tx/impl/Remit.cpp
src/ripple/app/tx/impl/SetRemarks.cpp
src/ripple/app/tx/impl/SetSignerList.cpp
src/ripple/app/tx/impl/SetTrust.cpp
src/ripple/app/tx/impl/SignerEntries.cpp
Expand Down Expand Up @@ -744,7 +745,10 @@ if (tests)
src/test/app/Remit_test.cpp
src/test/app/SHAMapStore_test.cpp
src/test/app/SetAuth_test.cpp
src/test/app/SetHook_test.cpp
src/test/app/SetHookTSH_test.cpp
src/test/app/SetRegularKey_test.cpp
src/test/app/SetRemarks_test.cpp
src/test/app/SetTrust_test.cpp
src/test/app/Taker_test.cpp
src/test/app/TheoreticalQuality_test.cpp
Expand All @@ -756,8 +760,6 @@ if (tests)
src/test/app/ValidatorKeys_test.cpp
src/test/app/ValidatorList_test.cpp
src/test/app/ValidatorSite_test.cpp
src/test/app/SetHook_test.cpp
src/test/app/SetHookTSH_test.cpp
src/test/app/Wildcard_test.cpp
src/test/app/XahauGenesis_test.cpp
src/test/app/tx/apply_test.cpp
Expand Down
5 changes: 5 additions & 0 deletions src/ripple/app/hook/impl/applyHook.cpp
Original file line number Diff line number Diff line change
@@ -1,12 +1,17 @@
#include <ripple/app/hook/applyHook.h>
#include <ripple/app/ledger/OpenLedger.h>
#include <ripple/app/ledger/TransactionMaster.h>
#include <ripple/app/misc/HashRouter.h>
#include <ripple/app/misc/NetworkOPs.h>
#include <ripple/app/misc/Transaction.h>
#include <ripple/app/misc/TxQ.h>
#include <ripple/app/tx/impl/Import.h>
#include <ripple/app/tx/impl/details/NFTokenUtils.h>
#include <ripple/basics/Log.h>
#include <ripple/basics/Slice.h>
#include <ripple/protocol/ErrorCodes.h>
#include <ripple/protocol/TxFlags.h>
#include <ripple/protocol/st.h>
#include <ripple/protocol/tokens.h>
#include <boost/multiprecision/cpp_dec_float.hpp>
#include <any>
Expand Down
4 changes: 2 additions & 2 deletions src/ripple/app/tx/impl/Remit.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
*/
//==============================================================================

#ifndef RIPPLE_TX_SIMPLE_PAYMENT_H_INCLUDED
#define RIPPLE_TX_SIMPLE_PAYMENT_H_INCLUDED
#ifndef RIPPLE_TX_REMIT_H_INCLUDED
#define RIPPLE_TX_REMIT_H_INCLUDED

#include <ripple/app/tx/impl/Transactor.h>
#include <ripple/basics/Log.h>
Expand Down
Loading
Loading