Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOUIssuerWeakTSH [DO NOT MERGE] #388

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

Conversation

tequdev
Copy link
Collaborator

@tequdev tequdev commented Oct 29, 2024

Affected to

  • CheckCash
  • EscrowCancel
  • EscrowCreate
  • EscrowFinish
  • OfferCreate
  • Payment
  • PaymentChannelClaim
  • PaymentChannelCreate
  • PaymentChannelFund
  • URITokenBuy
  • Remit

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

if (ctx_.view().rules().enabled(featureIOUIssuerWeakTSH))
{
additionalWeakTSH_.emplace(lowAcc);
additionalWeakTSH_.emplace(highAcc);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code in which additionalWeakTSH_ is processed probably needs to be changed to ensure if an account appears twice as a result of this change that it will always use the strongest TSH status

if (alreadyProcessed.find(tshAccountID) != alreadyProcessed.end())

@tequdev
Copy link
Collaborator Author

tequdev commented Nov 15, 2024

Need to resolve WeakTSH handling issue when transaction results in deletion of ledger object

#137

@RichardAH RichardAH force-pushed the dev branch 2 times, most recently from 77b8c83 to 532a471 Compare December 11, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants