-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IOUIssuerWeakTSH [DO NOT MERGE] #388
base: dev
Are you sure you want to change the base?
Conversation
if (ctx_.view().rules().enabled(featureIOUIssuerWeakTSH)) | ||
{ | ||
additionalWeakTSH_.emplace(lowAcc); | ||
additionalWeakTSH_.emplace(highAcc); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code in which additionalWeakTSH_ is processed probably needs to be changed to ensure if an account appears twice as a result of this change that it will always use the strongest TSH status
xahaud/src/ripple/app/tx/impl/Transactor.cpp
Line 1514 in 29b978b
if (alreadyProcessed.find(tshAccountID) != alreadyProcessed.end()) |
Need to resolve WeakTSH handling issue when transaction results in deletion of ledger object |
77b8c83
to
532a471
Compare
Affected to
High Level Overview of Change
Context of Change
Type of Change
.gitignore
, formatting, dropping support for older tooling)API Impact
libxrpl
change (any change that may affectlibxrpl
or dependents oflibxrpl
)