-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose C++ arrays to Python without data copying #123
Conversation
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
=======================================
Coverage 97.72% 97.72%
=======================================
Files 12 12
Lines 881 881
=======================================
Hits 861 861
Misses 20 20 Continue to review full report at Codecov.
|
7b98d67
to
c66f3c1
Compare
Wonder if it is worth precomputing the first 50 or so square roots of integers and not have to calculate them on the go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Nico, I flagged a couple of possible optimizations. Let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice :)
Now the returns of the hermite functions are not copied but are passed transparently into numpy arrays