-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for python 3.8 #138
Conversation
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
==========================================
+ Coverage 97.61% 97.74% +0.12%
==========================================
Files 12 12
Lines 839 887 +48
==========================================
+ Hits 819 867 +48
Misses 20 20
Continue to review full report at Codecov.
|
Thanks @thisac! If you click on the logs for the osx-wheels, you can see that Python 3.8 is working fine, which is great. However, the linux-wheels and the appveyor builds seem to be stopping at Python 3.7 🤔 Is there more info over at the https://github.com/joerick/cibuildwheel repo to help explain how we activate 3.8 for Linux/Appveyor? |
(Perhaps CircleCI and Appveyor are installing an old version of |
Seems to be working on appveyor, see https://ci.appveyor.com/project/josh146/hafnian/builds/31112782#L1592. Awesome! |
Everything seems to have worked! The last part of this PR will be:
|
The I'll fix the table right away. 🙂 |
Context:
Adds support for Python 3.8.
Description of the Change:
Removes
cp38-*
from the environment variableCIBW_SKIP
in.circleci/config.yml
(there was nocp38-*
inappveyor.yml
), and updates theREADME.rst
andsetup.py
files.Benefits:
Support for Python 3.8, which is good, especially since it's becoming the default Python version for many distributions.
Possible Drawbacks:
N/A
Related GitHub Issues:
closes #133