Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for python 3.8 #138

Merged
merged 7 commits into from
Feb 28, 2020
Merged

Support for python 3.8 #138

merged 7 commits into from
Feb 28, 2020

Conversation

thisac
Copy link
Contributor

@thisac thisac commented Feb 27, 2020

Context:
Adds support for Python 3.8.

Description of the Change:
Removes cp38-* from the environment variable CIBW_SKIP in .circleci/config.yml (there was no cp38-* in appveyor.yml), and updates the README.rst and setup.py files.

Benefits:
Support for Python 3.8, which is good, especially since it's becoming the default Python version for many distributions.

Possible Drawbacks:
N/A

Related GitHub Issues:
closes #133

@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #138 into master will increase coverage by 0.12%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   97.61%   97.74%   +0.12%     
==========================================
  Files          12       12              
  Lines         839      887      +48     
==========================================
+ Hits          819      867      +48     
  Misses         20       20
Impacted Files Coverage Δ
thewalrus/fock_gradients.py 100% <ø> (ø) ⬆️
thewalrus/quantum.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26df074...d6a37b1. Read the comment docs.

@thisac thisac requested review from josh146 and nquesada February 27, 2020 21:47
@thisac thisac changed the title Remove cp38 from skip Support for python 3.8 Feb 27, 2020
@josh146
Copy link
Member

josh146 commented Feb 27, 2020

Thanks @thisac! If you click on the logs for the osx-wheels, you can see that Python 3.8 is working fine, which is great. However, the linux-wheels and the appveyor builds seem to be stopping at Python 3.7 🤔 Is there more info over at the https://github.com/joerick/cibuildwheel repo to help explain how we activate 3.8 for Linux/Appveyor?

@josh146
Copy link
Member

josh146 commented Feb 27, 2020

(Perhaps CircleCI and Appveyor are installing an old version of cibuildwheel that doesn't have 3.8 support yet, so the pip command needs to install the latest version?

@josh146
Copy link
Member

josh146 commented Feb 28, 2020

Seems to be working on appveyor, see https://ci.appveyor.com/project/josh146/hafnian/builds/31112782#L1592. Awesome!

@josh146
Copy link
Member

josh146 commented Feb 28, 2020

Everything seems to have worked! The last part of this PR will be:

  • Updating the classifiers in the setup.py file, so that PyPI knows that The Walrus supports 3.8

  • Updating the table in the readme, to indicate 3.8 support. In fact, I would probably delete the table, and instead just have a bullet point list (the table is hard to maintain).

@josh146 josh146 added the enhancement New feature or request label Feb 28, 2020
@thisac
Copy link
Contributor Author

thisac commented Feb 28, 2020

Everything seems to have worked! The last part of this PR will be:

* Updating the `classifiers` in the `setup.py` file, so that PyPI knows that The Walrus supports 3.8

* Updating the table in the readme, to indicate 3.8 support. In fact, I would probably delete the table, and instead just have a bullet point list (the table is hard to maintain).

The classifiers in setup.py are already updated.

I'll fix the table right away. 🙂

@thisac thisac merged commit 96589a8 into master Feb 28, 2020
@thisac thisac deleted the test_python38 branch February 28, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Python 3.8
2 participants