Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photon number mean #148

Merged
merged 6 commits into from
Mar 16, 2020
Merged

Photon number mean #148

merged 6 commits into from
Mar 16, 2020

Conversation

nquesada
Copy link
Collaborator

Adds the ability to calculate the mean number of photons of a given mode in a Gaussian state.

@nquesada nquesada requested a review from thisac March 11, 2020 14:01
Copy link
Contributor

@thisac thisac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just added one suggestion for adding tolerance to a test. 🥇

Co-Authored-By: Theodor <theodor@xanadu.ai>
@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #148 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #148   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         880    887    +7     
=====================================
+ Hits          880    887    +7
Impacted Files Coverage Δ
thewalrus/quantum.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda8078...fd7f46c. Read the comment docs.

@nquesada nquesada merged commit b82ef3b into master Mar 16, 2020
@nquesada nquesada deleted the photon_number_mean branch March 16, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants