Remove py35 support #163
Merged
Remove py35 support #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No worries. f-strings are nice, and really cool. I like them! 😄 |
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 955 955
=========================================
Hits 955 955 Continue to review full report at Codecov.
|
josh146
reviewed
Apr 25, 2020
| @@ -160,7 +160,6 @@ def cythonize(x, compile_time_env=None): | |||
| "Operating System :: Microsoft :: Windows", | |||
| "Programming Language :: Python", | |||
| 'Programming Language :: Python :: 3', | |||
| 'Programming Language :: Python :: 3.5', | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
llvmliteno longer provide wheels for Python 3.5 causing CI tests to fail. This is easiest solved by removing support for Python 3.5 in The Walrus (which is something that is already planned).Description of the Change:
Support for Python 3.5 is removed from The Walrus by removing it from the CI suits, documentation and setup files.
Benefits:
CI tests will work again, and Python 3.5 support will be deprecated. Also, f-strings can be used.
Possible Drawbacks:
N/A
Related GitHub Issues:
#161 and #162 can now be merged.