Adds find_classical_subsystem #193
Conversation
nquesada
requested review from
josh146 and
thisac
and removed request for
josh146
|
Something strange seems to be happening with the windows builds 🤔 |
thewalrus/quantum.py
Outdated
| @@ -962,6 +964,30 @@ def is_classical_cov(cov, hbar=2, atol=1e-08): | |||
| return False | |||
|
|
|||
|
|
|||
| def find_classical_subsystem(cov, hbar=2, atol=1e-08): | |||
| """Find the largest integer `k` so that subsystem in modes `[0,1,...,k-1]` is a classical state. | |||
There was a problem hiding this comment.
What about if modes [2, 3, .., k] is a classical subsystem (e.g., there is some offset?)
There was a problem hiding this comment.
In general one could consider finding a classical subsystem in a any subset of the modes. This is a a combinatorially large space and thus extremely difficult to search. This is why I just search for this particular order. If the user wants to search for [2,3,...,k] they can permute the modes...
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 1062 1075 +13
=========================================
+ Hits 1062 1075 +13
Continue to review full report at Codecov.
|
Co-authored-by: Josh Izaac <josh146@gmail.com>
Co-authored-by: Josh Izaac <josh146@gmail.com>
Co-authored-by: Josh Izaac <josh146@gmail.com>
Adds the function
find_classical_subsystemwhich finds the largest integerkso that subsystem in modes[0,1,...,k-1]is a classical state.