Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes unnecessary function #194

Merged
merged 2 commits into from
Sep 3, 2020
Merged

Removes unnecessary function #194

merged 2 commits into from
Sep 3, 2020

Conversation

nquesada
Copy link
Collaborator

@nquesada nquesada commented Sep 2, 2020

Removes unnecessary function normal_ordered_complex_cov which can be implemented fully in terms of Qmat and Xmat.

@nquesada nquesada requested a review from thisac September 2, 2020 22:10
@nquesada nquesada changed the title Removes unnecesary function Removes unnecessary function Sep 3, 2020
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #194 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #194   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines         1075      1065   -10     
=========================================
- Hits          1075      1065   -10
Impacted Files Coverage Δ
thewalrus/quantum.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0213fc8...6d2f28d. Read the comment docs.

thisac
thisac approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@thisac thisac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix @nquesada. Is normal_ordered_complex_cov not used anywhere else than in normal_ordered_expectation?

@nquesada
Copy link
Collaborator Author

nquesada commented Sep 3, 2020

Correct, normal_ordered_complex_cov was only used in normal_ordered_expectation

@nquesada nquesada merged commit 91b7eec into master Sep 3, 2020
@nquesada nquesada deleted the remove_redudant_function branch September 3, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisac thisac thisac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nquesada @thisac