Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added C++ permanent source codes and removed Fortran ones #20

Merged
merged 8 commits into from
Jul 1, 2019

Conversation

bgupt
Copy link
Contributor

@bgupt bgupt commented Jun 28, 2019

Description of the Change: Permanent code with both fsum and quadruple precision is added to the repo

Benefits: All source codes are now in C++

Possible Drawbacks: None

Related GitHub Issues: None

… and Python test routines also added for permanent.
@bgupt bgupt requested review from josh146 and nquesada June 28, 2019 11:25
hafnian/_hafnian.py Outdated Show resolved Hide resolved
hafnian/__init__.py Outdated Show resolved Hide resolved
hafnian/_permanent.py Outdated Show resolved Hide resolved
hafnian/_permanent.py Outdated Show resolved Hide resolved
hafnian/tests/test_permanent.py Outdated Show resolved Hide resolved
src/permanent.hpp Outdated Show resolved Hide resolved
src/permanent.hpp Outdated Show resolved Hide resolved
src/permanent.hpp Outdated Show resolved Hide resolved
src/permanent.hpp Outdated Show resolved Hide resolved
}

}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are great tests!

@codecov
Copy link

codecov bot commented Jul 1, 2019

Codecov Report

Merging #20 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #20      +/-   ##
=======================================
- Coverage   95.01%   95%   -0.02%     
=======================================
  Files           8     8              
  Lines         562   560       -2     
=======================================
- Hits          534   532       -2     
  Misses         28    28
Impacted Files Coverage Δ
hafnian/samples.py 84.1% <ø> (ø) ⬆️
hafnian/_permanent.py 100% <100%> (ø) ⬆️
hafnian/_torontonian.py 100% <100%> (ø) ⬆️
hafnian/reference.py 98.73% <100%> (ø) ⬆️
hafnian/__init__.py 100% <100%> (ø) ⬆️
hafnian/_version.py 100% <100%> (ø) ⬆️
hafnian/quantum.py 98.63% <100%> (ø) ⬆️
hafnian/_hafnian.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46481c0...fa3ffc1. Read the comment docs.

src/permanent.hpp Outdated Show resolved Hide resolved
@josh146 josh146 merged commit e7798ef into master Jul 1, 2019
@josh146 josh146 deleted the permanentcpp branch July 1, 2019 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants