Using quad #201
Merged
Using quad #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nquesada
requested review from
trevor-vincent and
josh146
and removed request for
trevor-vincent
josh146
approved these changes
Sep 30, 2020
| @@ -171,14 +171,14 @@ inline T do_chunk_loops(std::vector<T> &mat, std::vector<T> &C, std::vector<T> & | |||
| comb[0] = 1.0; | |||
|
|
|||
| for (i = 1; i <= n / 2; i++) { | |||
| factor = traces[i - 1] / (2.0 * i); | |||
| factor = traces[i - 1] / static_cast<T> (2.0 * i); | |||
There was a problem hiding this comment.
Has the file been run through astyle? I just noticed that this casting looks like static_cast<t> () but the one above has different formatting static_cast<T>().
Comment on lines
+446
to
+448
| * In addition, this wrapper function automatically casts all matrices | ||
| * to type `complex<long double>`, allowing for greater precision than supported | ||
| * by Python and NumPy. |
| @@ -318,7 +318,7 @@ void apply_householder(std::vector<T> &A, std::vector<T> &v, size_t size_A, | |||
| size_t sizeH = v.size(); | |||
|
|
|||
| auto norm_v_sqr = norm_sqr(v); | |||
| if (norm_v_sqr == 0.) | |||
| if (norm_v_sqr == static_cast<T>(0.)) | |||
There was a problem hiding this comment.
(same here re: different formatting)
trevor-vincent
added a commit
that referenced
this pull request
Oct 19, 2020
* Add power trace optimization conforming to c++11 * include type_traits in the hope it solves MSVC prob * Fix typo * Apply astyle to eigenvalue_hafnian.hpp * Update include/eigenvalue_hafnian.hpp * Removes whitespaces * Using quad (#201) * First attempt. Failed * It works! * Fixes conversion issues * updates docstring * updates changelog * First attempt at MSVC2017 (#202) * Apply suggestions from code review * add docs * lower sphinx version * Update setup.py Co-authored-by: Nicolas Quesada <zeitus@gmail.com> Co-authored-by: Josh Izaac <josh146@gmail.com>
thisac
pushed a commit
that referenced
this pull request
Oct 20, 2020
* Add power trace optimization conforming to c++11 * include type_traits in the hope it solves MSVC prob * Fix typo * Apply astyle to eigenvalue_hafnian.hpp * Update include/eigenvalue_hafnian.hpp * Removes whitespaces * Using quad (#201) * First attempt. Failed * It works! * Fixes conversion issues * updates docstring * updates changelog * First attempt at MSVC2017 (#202) * Apply suggestions from code review * Adds C++ branching for loop hafnians in quad of odd size * Update setup.py * Adds tests for missing functality * Adds tests for missing functionality Co-authored-by: Trevor Vincent <tvincent@cita.utoronto.ca> Co-authored-by: Trevor Vincent <trevor-vincent@users.noreply.github.com> Co-authored-by: Josh Izaac <josh146@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the new functions to the python library, by creating specific functions for converting double into quad, do the calculations in quad and then return a double.