Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Banded unitaries #208

Merged
merged 16 commits into from
Oct 23, 2020
Merged

Banded unitaries #208

merged 16 commits into from
Oct 23, 2020

Conversation

nquesada
Copy link
Collaborator

Adds extra functionality for the generation of banded unitary matrices.

@nquesada nquesada requested a review from glassnotes October 21, 2020 13:37
@codecov
Copy link

codecov bot commented Oct 21, 2020 •
edited
Loading

Codecov Report

Merging #208 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #208   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1172      1195   +23     
=========================================
+ Hits          1172      1195   +23
Impacted Files Coverage Δ
thewalrus/random.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7be5b2...62ae1bb. Read the comment docs.

@glassnotes
Copy link
Contributor

Nice! Are you still looking for a way to smooth/fill in the missing chunks?

@nquesada
Copy link
Collaborator Author

hey @glassnotes --- It would definitely be nice if one could remove the dents. I gave some though to it yesterday but was unable to come up with anything good. On the other hand, this still does the job in that it gives a unitary with the specified bandwidth...
Maybe it is something to be left for a future PR?

@glassnotes
Copy link
Contributor

hey @glassnotes --- It would definitely be nice if one could remove the dents. I gave some though to it yesterday but was unable to come up with anything good. On the other hand, this still does the job in that it gives a unitary with the specified bandwidth...
Maybe it is something to be left for a future PR?

Yeah agreed - this seems like an interesting research problem to explore first!

@nquesada nquesada marked this pull request as ready for review October 21, 2020 19:45
glassnotes
glassnotes approved these changes Oct 23, 2020
View reviewed changes
thewalrus/tests/test_random.py Outdated Show resolved Hide resolved
.github/CHANGELOG.md
@@ -2,6 +2,8 @@

### New features

* Adds the function `random_banded_interferometer` to generate unitary matrices with a given bandwidth. [#208](https://github.com/XanaduAI/thewalrus/pull/208)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth mentioning random_block_interferometer also as a new feature, or is that not meant to be user-facing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too sure, seems a bit useless on its own.

thewalrus/random.py Outdated Show resolved Hide resolved
thewalrus/random.py Outdated Show resolved Hide resolved
thewalrus/random.py Outdated Show resolved Hide resolved
thewalrus/random.py Outdated Show resolved Hide resolved
thewalrus/tests/test_random.py Outdated Show resolved Hide resolved
thewalrus/tests/test_random.py Outdated Show resolved Hide resolved
thewalrus/tests/test_random.py Outdated Show resolved Hide resolved
thewalrus/tests/test_random.py Outdated Show resolved Hide resolved
@nquesada @glassnotes
Apply suggestions from code review
62ae1bb 
Co-authored-by: Olivia Di Matteo <2068515+glassnotes@users.noreply.github.com>
@nquesada nquesada merged commit bf89a89 into master Oct 23, 2020
@nquesada nquesada deleted the banded_unitaries branch October 23, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glassnotes glassnotes glassnotes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nquesada @glassnotes