Sparse loop hafnian #245

ziofil · 2021-05-30T13:00:04Z

Context: Loop hafnian computation does not exploit sparsity

Description of the Change: Loop hafnian computation now handles sparse matrices

Benefits: Fast computation of sparse matrices (few ms for 1000x1000 matrix with ~1000 non-zero entries)

Possible Drawbacks: Slower than default loop hafnian on matrices with fill factor above ~50%

Related GitHub Issues: None

codecov · 2021-05-30T13:44:27Z

Codecov Report

Merging #245 (3f6fb5c) into master (2624d91) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #245   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1293      1315   +22     
=========================================
+ Hits          1293      1315   +22

Impacted Files	Coverage Δ
thewalrus/__init__.py	`100.00% <ø> (ø)`
thewalrus/_hafnian.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2624d91...3f6fb5c. Read the comment docs.

thewalrus/_hafnian.py

nquesada · 2021-05-30T16:13:37Z

@ziofil : you will also need to update the CHANGELOG file.

Co-authored-by: Nicolas Quesada <zeitus@gmail.com>

.github/CHANGELOG.md

Co-authored-by: Nicolas Quesada <zeitus@gmail.com>

.github/CHANGELOG.md

Co-authored-by: Nicolas Quesada <zeitus@gmail.com>

thewalrus/tests/test_hafnian.py

Co-authored-by: Nicolas Quesada <zeitus@gmail.com>

antalszava

Looks good to me! 👍 Mostly considered code quality, had some suggestions.

thewalrus/_hafnian.py

thewalrus/tests/test_hafnian.py

.github/CHANGELOG.md

Co-authored-by: antalszava <antalszava@gmail.com>

ziofil

👍

josh146 · 2021-06-15T02:19:00Z

thewalrus/.ipynb_checkpoints/_hafnian-checkpoint.py

@@ -0,0 +1,296 @@
+# Copyright 2019 Xanadu Quantum Technologies Inc.


@ziofil don’t forget to delete the .vscode, .ipynb_checkpoints, and .DS_STORE directories before merging!

nquesada · 2021-06-22T19:14:47Z

.vscode/settings.json

+{
+    "python.pythonPath": "/Users/filippo/miniforge3/envs/tf24/bin/python"
+}


you'll need to delete this @ziofil

nquesada

Pending removing of unnecesary files this is ready to merge

thewalrus/__init__.py

thewalrus/_hafnian.py

Co-authored-by: Nicolas Quesada <zeitus@gmail.com>

.github/CHANGELOG.md

josh146 · 2021-06-23T08:46:11Z

@ziofil @nquesada for some reason readthedocs won't let me double check, but is the new sparse_hafnian function appearing in the documentation, specifically the list of Hafnian algorithms?

nquesada · 2021-06-23T14:14:59Z

Thanks for catching this @josh146 ! You are right we need to update the algorithms docs to include this PR and also the previous one by Tim for banded matrices.

ziofil added 4 commits May 30, 2021 08:22

adds sparse hafnian

ae0d3a4

adds sparse hafnian

276e1f0

fixed codecov issues

1bc870a

fixed CodeFactor issue

9935fcb

ziofil requested a review from nquesada May 30, 2021 13:03

ziofil changed the title ~~Sparse hafnian~~ Sparse loop hafnian May 30, 2021

complete coverage

3438904

nquesada reviewed May 30, 2021

View reviewed changes

thewalrus/_hafnian.py Outdated Show resolved Hide resolved

ziofil and others added 2 commits May 30, 2021 13:29

updated changelog

db91ea9

Update thewalrus/_hafnian.py

05d315b

Co-authored-by: Nicolas Quesada <zeitus@gmail.com>

nquesada reviewed May 30, 2021

View reviewed changes

.github/CHANGELOG.md Outdated Show resolved Hide resolved

Update .github/CHANGELOG.md

263a521

Co-authored-by: Nicolas Quesada <zeitus@gmail.com>

nquesada reviewed May 31, 2021

View reviewed changes

.github/CHANGELOG.md Outdated Show resolved Hide resolved

Update .github/CHANGELOG.md

33dbb8c

Co-authored-by: Nicolas Quesada <zeitus@gmail.com>

nquesada reviewed Jun 3, 2021

View reviewed changes

thewalrus/tests/test_hafnian.py Outdated Show resolved Hide resolved

Update thewalrus/tests/test_hafnian.py

21ddade

Co-authored-by: Nicolas Quesada <zeitus@gmail.com>

antalszava approved these changes Jun 10, 2021

View reviewed changes

ziofil and others added 9 commits June 10, 2021 20:59

Update thewalrus/_hafnian.py

20cd252

Co-authored-by: antalszava <antalszava@gmail.com>

Update thewalrus/_hafnian.py

e0d6c0f

Co-authored-by: antalszava <antalszava@gmail.com>

Update thewalrus/_hafnian.py

24ba72b

Co-authored-by: antalszava <antalszava@gmail.com>

Update thewalrus/_hafnian.py

8812504

Co-authored-by: antalszava <antalszava@gmail.com>

Update thewalrus/tests/test_hafnian.py

397350c

Co-authored-by: antalszava <antalszava@gmail.com>

Update .github/CHANGELOG.md

d660550

Co-authored-by: antalszava <antalszava@gmail.com>

Update .github/CHANGELOG.md

f53e75d

Co-authored-by: antalszava <antalszava@gmail.com>

Update thewalrus/_hafnian.py

2922b3a

Co-authored-by: antalszava <antalszava@gmail.com>

Update test_hafnian.py

a8bf92d

ziofil commented Jun 11, 2021

View reviewed changes

adds loop bool

3ec17da

ziofil added 2 commits June 10, 2021 22:02

adds tests

2e84a88

adds loop logic

8ef103a

josh146 reviewed Jun 15, 2021

View reviewed changes

Merge branch 'master' into sparse_hafnian

a4f7588

nquesada reviewed Jun 22, 2021

View reviewed changes

nquesada approved these changes Jun 22, 2021

View reviewed changes

removes unused files

240893f

nquesada reviewed Jun 22, 2021

View reviewed changes

thewalrus/__init__.py Outdated Show resolved Hide resolved

Apply suggestions from code review

abb4431

nquesada reviewed Jun 22, 2021

View reviewed changes

thewalrus/_hafnian.py Outdated Show resolved Hide resolved

Update thewalrus/_hafnian.py

5b997d5

Co-authored-by: Nicolas Quesada <zeitus@gmail.com>

ziofil commented Jun 23, 2021

View reviewed changes

.github/CHANGELOG.md Outdated Show resolved Hide resolved

Apply suggestions from code review

aa442e7

nquesada added 4 commits June 24, 2021 14:06

Adds the new algorithms into the docs

2f7aa5f

Merge branch 'master' into sparse_hafnian

0d76f45

Adds period

66f2b22

corrects typos

3f6fb5c

nquesada merged commit 09e72aa into master Jun 24, 2021

nquesada deleted the sparse_hafnian branch June 24, 2021 19:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sparse loop hafnian #245

Sparse loop hafnian #245

ziofil commented May 30, 2021

codecov bot commented May 30, 2021 •

edited

Loading

nquesada commented May 30, 2021

antalszava left a comment

ziofil left a comment

josh146 Jun 15, 2021

nquesada Jun 22, 2021

nquesada left a comment

josh146 commented Jun 23, 2021

nquesada commented Jun 23, 2021

		@@ -0,0 +1,296 @@
		# Copyright 2019 Xanadu Quantum Technologies Inc.

Sparse loop hafnian #245

Sparse loop hafnian #245

Conversation

ziofil commented May 30, 2021

codecov bot commented May 30, 2021 • edited Loading

Codecov Report

nquesada commented May 30, 2021

antalszava left a comment

Choose a reason for hiding this comment

ziofil left a comment

Choose a reason for hiding this comment

josh146 Jun 15, 2021

Choose a reason for hiding this comment

nquesada Jun 22, 2021

Choose a reason for hiding this comment

nquesada left a comment

Choose a reason for hiding this comment

josh146 commented Jun 23, 2021

nquesada commented Jun 23, 2021

codecov bot commented May 30, 2021 •

edited

Loading