Loop sampling #25
Merged
Loop sampling #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
+ Coverage 95% 95.21% +0.21%
==========================================
Files 8 8
Lines 560 564 +4
==========================================
+ Hits 532 537 +5
+ Misses 28 27 -1
Continue to review full report at Codecov.
|
josh146
approved these changes
Jul 12, 2019
|
|
||
| np.random.seed(20) | ||
| np.random.seed(137) |
There was a problem hiding this comment.
How come you needed to change the seed here?
There was a problem hiding this comment.
I just like 137, it is a more quantum electrodynamical number ;)
There was a problem hiding this comment.
@nquesada You have just given me my new favoite random number seed. 👍
| probs1[i] = hafnian(mat).real / factpref | ||
| probs1[i] = density_matrix_element( | ||
| mu_red, V_red, indices, indices, include_prefactor=True, hbar=hbar | ||
| ).real |
| assert np.allclose( | ||
| rel_freq, probs, rtol=rel_tol / np.sqrt(n_samples), atol=rel_tol / np.sqrt(n_samples) | ||
| ) | ||
|
|
bgupt
approved these changes
Jul 16, 2019
| probs1[i] = hafnian(mat).real / factpref | ||
| probs1[i] = density_matrix_element( | ||
| mu_red, V_red, indices, indices, include_prefactor=True, hbar=hbar | ||
| ).real |
|
|
||
| np.random.seed(20) | ||
| np.random.seed(137) |
There was a problem hiding this comment.
@nquesada You have just given me my new favoite random number seed. 👍
…nto loop_sampling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change:
Adds the ability to sample from Gaussian states with finite means, and at the same time simplifies the hafnian sampling functions. Also adds tests to the new functionality
Benefits:
Can sample from Gaussian states with non zero means.
Possible Drawbacks:
The syntax is slightly awkward in that the mean vector is (an optional argument) passed after the covariance matrix and the number of samples. Maybe it might be a good idea to use this syntax also in the quantum functions, i.e. make the vector of means of optional.
Related GitHub Issues: