Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit numpy version to 1.20 to prevent numba error about incompatibility with numpy #279

Closed
wants to merge 1 commit into from

Conversation

lneuhaus
Copy link

Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@josh146
Copy link
Member

josh146 commented Aug 27, 2021

Hey @lneuhaus! Thanks for this. Instead of limiting NumPy, can we instead limit numba<0.54?

I think better to restrict Numba (a package less users might already have installed) than NumPy, to avoid potential dependency resolving issues

@josh146
Copy link
Member

josh146 commented Aug 27, 2021

Note: I've already made this change in #278

@lneuhaus lneuhaus closed this Aug 27, 2021
@lneuhaus lneuhaus deleted the limit-numpy-version branch August 27, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants