Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cutoff handling #283

Merged
merged 31 commits into from
Sep 12, 2021
Merged

Cutoff handling #283

merged 31 commits into from
Sep 12, 2021

Conversation

ziofil
Copy link
Collaborator

@ziofil ziofil commented Sep 9, 2021

in order to use tf.numpy_function the Hermite multidimensional functions need to handle a cutoff that is an ndarray

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #283 (f53495e) into master (67084f3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #283   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1428      1431    +3     
=========================================
+ Hits          1428      1431    +3     
Impacted Files Coverage Δ
thewalrus/_hermite_multidimensional.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67084f3...f53495e. Read the comment docs.

@ziofil ziofil requested review from thisac and nquesada September 9, 2021 19:02
Copy link
Contributor

@thisac thisac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ziofil. I see why this is needed, although I think a comment just above the int-casting would make sense to add. 🙂

ziofil and others added 2 commits September 9, 2021 20:23
Co-authored-by: Theodor <theodor@xanadu.ai>
@ziofil ziofil requested a review from thisac September 10, 2021 00:44
@ziofil ziofil merged commit 9f6e450 into master Sep 12, 2021
@ziofil ziofil deleted the cutoff-handling branch September 12, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants