Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on repoze.lru Python package #293

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

Mandrenkov
Copy link
Contributor

Context:
There is a Python installation dependency on repoze.lru which uses a license that may be unsuitable for some projects.

Description of the Change:

  • Removed repoze.lru as a Python dependency; functools.lru_cache() is now used in place of repoze.lru_cache().

Benefits:

  • The Walrus has fewer dependencies.

Possible Drawbacks:
None.

Related GitHub Issues:
None.

@Mandrenkov Mandrenkov requested a review from thisac November 1, 2021 15:52
@nquesada nquesada self-requested a review November 1, 2021 15:59
@nquesada
Copy link
Collaborator

nquesada commented Nov 1, 2021

Thanks @Mandrenkov ! This is a most welcome change.

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #293 (d1b298a) into master (be0339e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #293   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1446      1446           
=========================================
  Hits          1446      1446           
Impacted Files Coverage Δ
thewalrus/_low_rank_haf.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be0339e...d1b298a. Read the comment docs.

Copy link
Contributor

@thisac thisac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mandrenkov! 💯

@Mandrenkov Mandrenkov merged commit bf6679e into master Nov 1, 2021
@Mandrenkov Mandrenkov deleted the sc-10736-remove-repoze-lru branch November 1, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants