Use numba implementation of multidimensional Hermite polynomials #295
Conversation
…d of c++ - Checks and prep operations on `hermite_multidimensional_numba` are implemented on `hermite_multidimensional`. - `.libwalrus.renorm_hermite_multidimensional` is deprecated in favour of `_hermite_multidimensional_numba`
- implement `_hermite_multidimensional_renorm` - remove `*_numba` postfix from private functions - directly call private functions from `hermite_multidimensional`
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 1451 1458 +7
=========================================
+ Hits 1451 1458 +7
Continue to review full report at Codecov.
|
…te_multidimensional
|
seems like this is almost ready to go except for a test failing |
|
Related changes on strawberryfields are addressed on PR #646 |
There was a problem hiding this comment.
@sduquemesa : you could now delete ther hermite.hpp file in include and also the corresponding c++ tests
|
Thank you @nquesada! |
|
@sduquemesa : you have not added your name here: https://github.com/XanaduAI/thewalrus/blob/master/.github/ACKNOWLEDGMENTS.md and also don't forget to update the CHANGELOG |
…anaduAI/thewalrus into numba-hermite-multidimensional
There was a problem hiding this comment.
You forgot to add your name in the list of contributors for this release @sduquemesa . I guess you can do that later. Otherwise great work! Super happy to start getting rid of hard to maintain hard to compile C++ code.
Context: PR #280 implemented a fully numbified multidimensional Hermite polynomials
Description of the Change: This PR deprecates the C++ implementation of multidimensional Hermite polynomials
in favor of the numba implementation
Benefits: The Walrus has less C++ dependencies
Possible Drawbacks: Speed, but as commented in PR #280, the numba implementation is faster than the C++ one
Related GitHub Issues: PR #646 on strawberryfields