the Bristolian #316
the Bristolian #316
Conversation
Codecov Report
@@ Coverage Diff @@
## master #316 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 1575 1603 +28
=========================================
+ Hits 1575 1603 +28
Continue to review full report at Codecov.
|
|
Almost there @jakeffbulmer : you just need a test for the branching here:
You can likely parametrize one of the test you wrote... |
| @@ -118,7 +118,7 @@ | |||
| interferometer, | |||
| grad_hermite_multidimensional, | |||
| ) | |||
| from ._permanent import perm, permanent_repeated | |||
| from ._permanent import perm, permanent_repeated, brs, ubrs | |||
There was a problem hiding this comment.
@jakeffbulmer : you probably want to add brs and ubrs into the __all__ list in line 132
There was a problem hiding this comment.
and also into the autosummary in line 78. This is so that they are included when the documentation is generated.
thewalrus/_permanent.py
Outdated
| Returns: | ||
| float: probability of Fock state, n, scattering to m, through an interferometer, U | ||
| """ | ||
| assert sum(n) == sum(m) |
There was a problem hiding this comment.
since this is not a jitted function, it would be better if you RaiseValueError instead of using assert. You will need to also add a test checking that the exception is raised correctly.
thewalrus/_permanent.py
Outdated
| assert len(n) == T.shape[1] | ||
| assert len(d) == T.shape[0] | ||
| assert T.shape[0] <= T.shape[1] |
There was a problem hiding this comment.
Same as above. RaiseValueError is preferred.
|
|
||
|
|
There was a problem hiding this comment.
These tests are really great. Fantastic work @jakeffbulmer !
thewalrus/_permanent.py
Outdated
| from numba import jit, prange | ||
|
|
||
| from scipy.special import factorial | ||
| from scipy.linalg import sqrtm |
There was a problem hiding this comment.
it seems like you don't need sqrtm anymore
Co-authored-by: Nicolas Quesada <991946+nquesada@users.noreply.github.com>
|
Thanks @sduquemesa |
Context:
matrix functions for calculating threshold detector statistics of Fock states interfering in linear optical interferometers.
Description of the Change:
New functions, the "Bristolian"
brsand the "Unitary Bristolian"ubrsare added to_permanent.pyand imported in__init__.py.Benefits:
Allows for calculation of threshold detector statistics in experiments where Fock states are interfered in linear optical interferometers.
There are also new functions in _permanent.py called
fock_threshold_probandfock_probwhich make it easy to get the probabilities of Fock state interference in linear optics. These latter functions are not imported in the init file, but maybe they could be useful elsewhere?Possible Drawbacks:
What could possibly go wrong?
Related GitHub Issues: