Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes unnecesary statements #329

Merged
merged 3 commits into from
Feb 9, 2022
Merged

removes unnecesary statements #329

merged 3 commits into from
Feb 9, 2022

Conversation

nquesada
Copy link
Collaborator

@nquesada nquesada commented Feb 9, 2022

Removes unnecesary condition.

In the early days, to calculate a loop hafnian of odd size, we will turn the matrix into an even size one by adding one extra column and row of zeros and a one in the diagonal. This is no longer needed due to the methods from @jakebulmer .

This PR removes this vestigial code.

@nquesada nquesada requested a review from jakeffbulmer February 9, 2022 20:36
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #329 (3093e8c) into master (2e32e46) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #329   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         1645      1644    -1     
=========================================
- Hits          1645      1644    -1     
Impacted Files Coverage Δ
thewalrus/_hafnian.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e32e46...3093e8c. Read the comment docs.

Copy link
Contributor

@jakeffbulmer jakeffbulmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep all looks good!

@nquesada nquesada merged commit 7f56333 into master Feb 9, 2022
@nquesada nquesada deleted the remove_add_one_for_loops branch February 9, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants