-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant Qmat, Amat calls from generate_hafnian_sample #343
Conversation
Codecov Report
@@ Coverage Diff @@
## master #343 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 1726 1725 -1
=========================================
- Hits 1726 1725 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @thonic! Great find! I only had a few minor comments that would be good to address. Let me know if you have any questions about them.
@thisac I agree with all the comments, I have changed the commits accordingly, thank you. |
Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com>
@sduquemesa done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the contribution @thonic!
Context:
There is an extra call of the
Qmat
function in thegenerate_hafnian_sample
function.Description of the Change:
Remove redundant call of
Qmat
,Amat
fromgenerate_hafnian_sample
.Benefits:
Removed redundant code
Possible Drawbacks:
None
Related GitHub Issues:
None