Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve type conflict preventing the pip wheel to build correctly #4

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Solve type conflict preventing the pip wheel to build correctly #4

merged 1 commit into from
Nov 26, 2018

Conversation

emaballarin
Copy link
Contributor

As per subject, this PR tries to fix the following error

src/rlhafnian.c: At top level:
src/rlhafnian.c:405:8: error: conflicting types for ‘hafnian_loops’
double hafnian_loops(double *mat, int n)
^~~~~~~~~~~~~
In file included from src/rlhafnian.c:14:
src/rlhafnian.h:33:7: note: previous declaration of ‘hafnian_loops’ was here
telem hafnian_loops(telem *mat, int n);

arising when trying to build the pip wheel (i.e.: make wheel) or installing the package directly from PyPi or git repository.

The error, somehow, falls through CI testing (though still being present in the logfiles).

According to the testsuite, and some specific ad-hoc testing, it shouldn't break things.

@nquesada
Copy link
Collaborator

Thanks!

@nquesada nquesada merged commit 2e7a128 into XanaduAI:master Nov 26, 2018
josh146 added a commit that referenced this pull request Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants