Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #57 and #56 #58

Merged
merged 1 commit into from
Sep 23, 2019
Merged

fixes #57 and #56 #58

merged 1 commit into from
Sep 23, 2019

Conversation

josh146
Copy link
Member

@josh146 josh146 commented Sep 23, 2019

Description of the Change: Updates the makefile to by default use a defined environment variable EIGEN_INCLUDE_DIR for the location of the eigen3 include directory. If not defined, it falls back to /usr/include/eigen3. Also removes example-f90 target from the examples makefile.

Benefits: More easily installable

Possible Drawbacks: n/a

Related GitHub Issues: Fixes #56 and #57

@josh146 josh146 added the bug Something isn't working label Sep 23, 2019
@josh146 josh146 requested a review from nquesada September 23, 2019 21:48
@codecov
Copy link

codecov bot commented Sep 23, 2019

Codecov Report

Merging #58 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files           9        9           
  Lines         656      656           
=======================================
  Hits          625      625           
  Misses         31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a133e04...73fbc1a. Read the comment docs.

@josh146 josh146 merged commit e56cc68 into master Sep 23, 2019
@josh146 josh146 deleted the makefile_bug_fixes branch September 23, 2019 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make test-cpp hard codes the eigen include dir to /usr/include/eigen3
1 participant