Hermite improve #93
Merged
Hermite improve #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 95.75% 96.19% +0.44%
==========================================
Files 11 11
Lines 800 894 +94
==========================================
+ Hits 766 860 +94
Misses 34 34
Continue to review full report at Codecov.
|
|
Fun fact. The very first implementation of |
josh146
approved these changes
Nov 20, 2019
| @@ -21,6 +21,7 @@ All probability amplitudes of a pure Gaussian state | |||
| All matrix elements of a general Gaussian state :func:`thewalrus.quantum.density_matrix()` | |||
| A particular probability amplitude of pure Gaussian state :func:`thewalrus.quantum.pure_state_amplitude()` | |||
| A particular matrix element of a general Gaussian state :func:`thewalrus.quantum.density_matrix_element()` | |||
| The Fock representation of a Gaussian unitary :func:`thewalrus.quantum.fock_tensor()` | |||
| ================================================================================ ============================= | |||
| for (int ii = 0; ii < dim; ii++) { | ||
| H[nextCoordinate] = H[nextCoordinate] + R(k, ii) * y(ii, 0); | ||
| } | ||
| H[nextCoordinate] = H[nextCoordinate] + y(k, 0); |
There was a problem hiding this comment.
Was + R(k, ii) * y(ii, 0) the original matrix multiplication that is now redundant?
| @@ -776,7 +776,7 @@ TEST(LoopHafnianEigenComplex, EvenRandom) { | |||
|
|
|||
| } | |||
|
|
|||
| // Check loop hafnian with eignevalues for complex matrices with odd dimensions. | |||
| // Check loop hafnian with eigenvalues for complex matrices with odd dimensions. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving the speed of the hermite polynomials and also changing their definition
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
The docs need to be updated to reflect the new definition
Related GitHub Issues: