Define _GNU_SOURCE in Linux #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayFoxRox
reviewed
Apr 27, 2019
JayFoxRox
reviewed
Apr 27, 2019
| @@ -236,6 +236,7 @@ | |||
|
|
|||
| #if defined( __LINUX__ ) | |||
| #define _LARGEFILE64_SOURCE | |||
| #define _GNU_SOURCE | |||
There was a problem hiding this comment.
I'm not sure if this is really Linux specific. It should also be necessary on MSYS2 etc.
There was a problem hiding this comment.
Good catch, now its treated as GCC specific instead. 👍
There was a problem hiding this comment.
Commit title has since been changed. 👍
JayFoxRox
reviewed
Apr 27, 2019
dracc
force-pushed
the
gnusource
branch
2 times, most recently
from
8c14a21 to
b8526f6
Compare
Silences an asprintf() warning.
|
I think I'd have preferred |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silences an asprintf() warning.